CUNY Academic Commons

Okay. I agree that this is high priority, as members could find this bug frustrating.

Do you think it is worth writing about known bugs anywhere? What are your thoughts now about the timing of the 1.1.1 release?

I'd like to do a 1.1.1 either tomorrow or Thursday that fixes the more annoying bugs. I'd say it's not worthwhile to write about known bugs until after that.

Sounds good - thanks.

I just wrote a little script to detect this, and the good news is that, on my local installation (and a several-months-out-of-date database) there are only a dozen or so instances of the problem. So we're probably not looking at something huge.

In any case, it will be fixed with 1.1.1.

Here's the script: https://github.com/castiron/cac/commit/98558283a60af248b001be3e3b35a7a619b4ee89

Ron or Chris, if one of you could take 5 minutes to glance at it and make sure that nothing insane is happening, I'd appreciate it :)

Attaching a patch in case that's easier than pulling from my new fangled branch

Boone,
I don't have time to try running this but looking over it the logic seems OK to me. I also don't know much about how the group member and group meta tables are so could only look at the general logic there.

I don't know if this will be an issue or not but it appears that when you use unset() on arrays it doesn't alter the indexes for the items in the array so they can be messed up. In the comments on this php.net page is where I saw it.
http://php.net/manual/en/function.unset.php
Look for the comment
j dot vd dot merwe at enovision dot net
26-Aug-2010 12:08

I'm guessing that would only be a problem if you wanted to loop back through the array again but you can do what that person has and add something like
$subs = array_values($subs);
to reset the indexes.

Thanks, Chris. I'm aware of how unset() works with array keys. In this case the indexes don't matter (since the arrays in question are associative - indexed by member id - I don't want them to be reindexed).