Project

General

Profile

Bug #4953

Replying to a discussion via email does not remove all of the quoted part

Added by Raffi Khatchadourian about 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Reply By Email
Target version:
Start date:
2015-11-27
Due date:
% Done:

0%

Estimated time:

Description

I replied to a discussion via email and I noticed that some of the quoted text is not removed in the post. An example can be found at http://commons.gc.cuny.edu/groups/lms-blackboard-and-alternatives/forum/topic/aws-marketplace-for-education-research/#post-44717. I have attached the email from which my reply originated.

History

#1 Updated by Raffi Khatchadourian about 6 years ago

The fix may lie somewhere in bp_rbe_remove_email_client_signature().

#2 Updated by Raffi Khatchadourian about 6 years ago

Raffi Khatchadourian wrote:

The fix may lie somewhere in bp_rbe_remove_email_client_signature().

Interestingly, there's even a check for a colon:

// last character of last line ends with a colon!
if ( substr( rtrim( $lines[0] ), -1 ) === ':' )

#3 Updated by Boone Gorges about 6 years ago

  • Category name set to Reply By Email
  • Status changed from New to Assigned
  • Assignee set to Raymond Hoh
  • Target version set to Future release

Yeah, it looks like it ought to have been caught by https://github.com/r-a-y/bp-reply-by-email/blob/master/includes/bp-rbe-functions.php#L860.

Assigning to Ray to have a look.

#4 Updated by Raymond Hoh about 6 years ago

Thanks for the report, Raffi.

Will look into this.

#5 Updated by Raymond Hoh about 6 years ago

  • Target version changed from Future release to 1.9

Turns out I already addressed this, but forgot to port this over to the Commons!

Added in commit 671bf8a.

Fix will be deployed next week for 1.9.

#6 Updated by Raymond Hoh about 6 years ago

  • Status changed from Assigned to Resolved

Forgot to close this!

Also available in: Atom PDF