Bug #4953
closedReplying to a discussion via email does not remove all of the quoted part
0%
Description
I replied to a discussion via email and I noticed that some of the quoted text is not removed in the post. An example can be found at http://commons.gc.cuny.edu/groups/lms-blackboard-and-alternatives/forum/topic/aws-marketplace-for-education-research/#post-44717. I have attached the email from which my reply originated.
Files
Updated by Raffi Khatchadourian over 8 years ago
The fix may lie somewhere in bp_rbe_remove_email_client_signature().
Updated by Raffi Khatchadourian over 8 years ago
Raffi Khatchadourian wrote:
The fix may lie somewhere in bp_rbe_remove_email_client_signature().
Interestingly, there's even a check for a colon:
// last character of last line ends with a colon! if ( substr( rtrim( $lines[0] ), -1 ) === ':' )
Updated by Boone Gorges over 8 years ago
- Category name set to Reply By Email
- Status changed from New to Assigned
- Assignee set to Raymond Hoh
- Target version set to Future release
Yeah, it looks like it ought to have been caught by https://github.com/r-a-y/bp-reply-by-email/blob/master/includes/bp-rbe-functions.php#L860.
Assigning to Ray to have a look.
Updated by Raymond Hoh over 8 years ago
Thanks for the report, Raffi.
Will look into this.
Updated by Raymond Hoh over 8 years ago
- Target version changed from Future release to 1.9
Turns out I already addressed this, but forgot to port this over to the Commons!
Added in commit 671bf8a.
Fix will be deployed next week for 1.9.
Updated by Raymond Hoh over 8 years ago
- Status changed from Assigned to Resolved
Forgot to close this!