Project

General

Profile

Bug #5179

homepage slider image broken

Added by Matt Gold over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority name:
High
Assignee:
Category name:
Homepage Slides
Target version:
Start date:
2016-01-28
Due date:
% Done:

0%

Estimated time:

Description

Hi Scott -- looks to me like the first image on the homepage slider, for social paper, is broken. Can you please take a look and also review others? I saw at least one other broken image, too. Thanks for your help with this.

History

#1 Updated by Boone Gorges over 6 years ago

The image is working for me.

#2 Updated by Matt Gold over 6 years ago

  • Status changed from Assigned to Rejected

Hmm. I see it now, too. Maybe just a weird temporary problem. Nevermind!

#3 Updated by Matt Gold over 6 years ago

reopening, as this just happened to me again -- this time at a different computer (at work, whereas yesterday the issue was at home). Screenshot attached

#4 Updated by Boone Gorges over 6 years ago

  • Target version set to 1.9.6

It's an SSL problem. I don't know why it's just started now. I've put a temporary fix into place until I can figure it out.

#5 Updated by Matt Gold over 6 years ago

thanks so much, Boone.

#6 Updated by Boone Gorges over 6 years ago

  • Assignee changed from Boone Gorges to Raymond Hoh

Reassigning to Ray. Ray, could you please poke around to see if you can figure this out? On the production site, certain image assets that presumably used to be scheme-sensitive are now being loaded over HTTP even when is_ssl(). I put in a hotfix for post-gallery-widget (see cac_hero_image_ssl() in wp-content/themes/bp-nelo/functions.php) but it's also happening with the lazyload avatar placeholders on the home page.

#7 Updated by Raymond Hoh over 6 years ago

  • Status changed from Assigned to Resolved

I was able to duplicate this on my local HTTPS setup.

Issue was with BP Widget Cache using the cached HTTP response when SSL is in effect. To remedy this, if SSL in on, I'm switching out all HTTP links with HTTPS in BP Widget Cache:
https://github.com/cuny-academic-commons/cac/commit/c3008c246e3588733cbdaabeb77a8cd993c61a95

This appears to fix the issue.

Boone, you can probably remove the post-gallery-widget hotfix on production.

#8 Updated by Matt Gold over 6 years ago

Woah -- this is a longstanding issue -- it would be pretty awesome if you've fixed it, Ray!!

#9 Updated by Boone Gorges over 6 years ago

Ah, the cache. Never dawned on me. Thanks, Ray!

#10 Updated by Boone Gorges over 6 years ago

On release, I saw that Ray's fix was working properly in some cases, but not all. 'srcset' attributes were, in some cases, still being set to http://. It looks like this is a known issue with WP 4.4's responsive image functionality and an SSL setup like ours (http:// home URL, available over SSL). https://github.com/cuny-academic-commons/cac/commit/e7b87c74bd4f5855a211be9f42d5ff966ffa23ab is a fix that appears to cover the bases.

Also available in: Atom PDF