Project

General

Profile

Bug #5257

Social Paper: Comment indicator disappears after adding a comment to a paragraph with no count

Added by Raymond Hoh almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Social Paper
Target version:
Start date:
2016-02-24
Due date:
% Done:

0%

Estimated time:

Description

See https://redmine.gc.cuny.edu/issues/5255#note-5

Luke's original report is as follows:

Seeing issue where when I submit a comment it is successfully stored (screenshot 1), then when I click elsewhere on the page, the comment and comments indicator are not visible (screenshot 2) until I reload the page (screenshot 3).

Using Chrome.

Screenshot 1:

Screenshot 2:

Screenshot 3:

History

#1 Updated by Raymond Hoh almost 3 years ago

  • Status changed from New to Hold

I've submitted a fix for this to the Inline Comments repo.

Boone, in the meantime, should I merge the fix into the 1.9.x milestone for now?

#2 Updated by Boone Gorges almost 3 years ago

Thanks, Ray!

Ok with me to merge into the 1.9 branch, though Iwant to be careful it's not lost on IC update. Is the author usually good about accepting PRs? Is it likely that your PRs will be accepted before his next release? If not, I will blacklist IC from my autoupdate routine.

#3 Updated by Raymond Hoh almost 3 years ago

  • Status changed from Hold to Resolved

Fix added to 1.9.x branch:
https://github.com/cuny-academic-commons/cac/commit/8e1405a380122c99ac6cd0cc0372de718c31da17

Is the author usually good about accepting PRs? Is it likely that your PRs will be accepted before his next release?

Yeah, the author is quite good with accepting PRs. I'm pretty sure he will merge the fixes once he is able to look at them.

Also available in: Atom PDF