Project

General

Profile

Actions

Bug #5415

closed

Received a "Your RBE Message could not be posted" error even though the message posted

Added by Matt Gold over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Reply By Email
Target version:
Start date:
2016-04-06
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Hi Ray,

I forwarded a message to a group and it posted -- http://commons.gc.cuny.edu/groups/digital-humanities-initiative/forum/topic/fwd-dhsi-day-of-2016/

However, I received an error message (screenshot attached) saying that it hadn't posted


Files

Actions #1

Updated by Matt Gold over 8 years ago

FYi -- had this happen again. The specific error I received was "Could not be posted because it appears you already created this topic before."

Actions #2

Updated by Raymond Hoh over 8 years ago

I'm looking into this.

It looks like after a new bbPress forum topic is posted, RBE doesn't appear to close the current IMAP connection properly.

Actions #3

Updated by Raymond Hoh over 8 years ago

  • Status changed from New to Resolved
  • Target version set to 1.9.13

So this was a pain to debug!

Fixed in https://github.com/cuny-academic-commons/cac/commit/2eff06df7fe87f6eb25e5f1ea4b8998aebce65f7.

After countless debugging, I narrowed down the problem to the BP Multiple Forum Post plugin.

BP Multiple Forum Post hooks onto the bbPress hook - 'bbp_new_topic_post_extras' with the bpmfp_create_duplicate_topics() function. This hook is also used by RBE to emulate bbPress' new topic post routine.

Unfortunately, the bpmfp_create_duplicate_topics() uses exit() when it doesn't find its form data from the frontend topic post form. This broke RBE's IMAP disconnection routine since the exit() call stops the execution of all other scripts, which includes RBE.

To fix this conflict with RBE, I've altered BPMFP so the nonce and exit() check is done a little further below so BPMFP doesn't prematurely break scripts like RBE.

Actions #4

Updated by Boone Gorges over 8 years ago

Yikes! Thanks, Ray. Adding Dan as a watcher so that he can merge this fix into his Github repo.

Actions #5

Updated by Raymond Hoh over 8 years ago

Fix already applied to the BPMFP repo :)

Actions #6

Updated by Boone Gorges over 8 years ago

:gold-medal-emoji:

Actions #7

Updated by Matt Gold over 8 years ago

Thanks, Ray!

Actions #8

Updated by Daniel Jones over 8 years ago

Wow sorry about that! Thanks for fixing, Ray.

Actions

Also available in: Atom PDF