Project

General

Profile

Bug #5451

"pre" formatting stripped from group forum email notifications

Added by Boone Gorges almost 3 years ago. Updated almost 3 years ago.

Status:
Duplicate
Priority name:
Normal
Assignee:
Category name:
Email Notifications
Target version:
Start date:
2016-04-14
Due date:
% Done:

0%

Estimated time:

Description

See http://commons.gc.cuny.edu/groups/cuny-academic-commons-subcommittee/forum/topic/effect-of-email-blast-on-inactive-users-preliminary-numbers/#post-47972. The pre tags were stripped in the email notification.

Adding Ray as a watcher just in case his steel-trap mind immediately seizes upon the reason.

History

#1 Updated by Boone Gorges almost 3 years ago

  • Description updated (diff)

#2 Updated by Raymond Hoh almost 3 years ago

The pre tag in group email notifications is stripped because BP's activity KSES filter (bp_activity_filter_kses()) does not list pre as a whitelisted element.

Since GES relies on BP's activity content, that is why pre tags do not show up.

If we want to use pre, we would need to add it to the activity KSES filter.

If we add pre to emails, we would need to ensure that plain-text conversion works properly as well. A potential issue here is with the email line-wrap limit in email clients. If someone is using pre with a long line character count, the content could look incorrect, but I guess that is relatively a minor thing.

#3 Updated by Boone Gorges almost 3 years ago

  • Target version changed from 1.9.14 to Future release

Thanks, Ray. This is not important enough to try to fix right this moment :)

#4 Updated by Raymond Hoh almost 3 years ago

  • Status changed from New to Duplicate
  • Target version changed from Future release to 1.10

I believe #5313 should address this.

Going to mark this as a duplicate.

Also available in: Atom PDF