Project

General

Profile

Support #6728

JITP submissions: copyediting iframe content

Added by Ben Miller almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
-
Target version:
Start date:
2016-11-15
Due date:
% Done:

0%

Estimated time:

Description

As we proceed toward the launch of JITP Issue Ten, we're combing through all the pages and making sure everything appears to be in order. And, of course, finding a few things here and there that aren't.

In the filebase relevant to shortcode [jitp-morethanassessment], added in https://github.com/cuny-academic-commons/cac/commit/3ca8e981b5d32f970f80c649d1a312deb4ca0013 as part of https://redmine.gc.cuny.edu/issues/5792, three <img> links have the wrong capitalization. The easiest fix, I believe, would be to change uppercase *.JPG to lowercase *.jpg in these three files:
  • JITP-Bartlett-et-al/imgs/bio-reflective-example.JPG
  • JITP-Bartlett-et-al/imgs/student-support-2.JPG
  • JITP-Bartlett-et-al/imgs/cohort-working.JPG

This would avoid having to find and edit the html on separate pages, by simply matching the filenames to the ones expected by the existing html.

Many thanks!
Ben

style.css (11.1 KB) style.css Ben Miller, 2016-11-21 05:04 PM

History

#1 Updated by Matt Gold almost 3 years ago

  • Status changed from New to Assigned
  • Assignee set to Boone Gorges

#2 Updated by Boone Gorges almost 3 years ago

  • Status changed from Assigned to Reporter Feedback
  • Target version set to 1.10.2

Hi Ben - I've applied the changes on the production server. Can you verify?

#3 Updated by Ben Miller almost 3 years ago

These three look great. Thank you!

Maddeningly, we just found one more broken image that was masked by being directly adjacent to an image with a white background and text at the top. Same problem, same folder:
  • JITP-Bartlett-et-al/imgs/eng-about.JPG --> JITP-Bartlett-et-al/imgs/eng-about.jpg

#4 Updated by Ben Miller almost 3 years ago

Ugh, kicking self. (So many times, it seems...)
Please, in the words of Willie Wonka, "strike that; reverse it":

In this case, it's the capital JPG that works.

  • JITP-Bartlett-et-al/imgs/eng-about.JPG <-- JITP-Bartlett-et-al/imgs/eng-about.jpg

#5 Updated by Boone Gorges almost 3 years ago

There is already a file called eng-about.JPG, and none called eng-about.jpg. So there's nothing for me to do?

#6 Updated by Ben Miller almost 3 years ago

Figured it out: in a haze of sleep-debt, I got turned around. (I even mis-posted this response, within minutes, to the do-not-reply address, and didn't realize until a delivery-failed notification just arrived. It was a bad night.) When you get a chance, can you please just toggle the capitalization, as originally requested?

  • JITP-Bartlett-et-al/imgs/eng-about.JPG --> JITP-Bartlett-et-al/imgs/eng-about.jpg

Grateful and embarrassed,
Ben

#7 Updated by Boone Gorges almost 3 years ago

Hi Ben - I've made the change. Please have a look.

#8 Updated by Ben Miller almost 3 years ago

Looks perfect, Boone. Thank you!

#9 Updated by Ben Miller almost 3 years ago

Dear Boone,

Another set of eyes, another set of missing images. I'm very sorry we didn't find all these in one clean sweep! When you're able to, would you please change the names of the following three images, in the same way as before?
  • JITP-Bartlett-et-al/imgs/ahead-banner.JPG
  • JITP-Bartlett-et-al/imgs/sv-banner.JPG
  • JITP-Bartlett-et-al/imgs/ref-banner.JPG
We also have an updated CSS file, attached. Could you replace it at the following location?
  • JITP-Bartlett-et-al/stylesheets/style.css

Very gratefully,
Ben

#10 Updated by Boone Gorges almost 3 years ago

  • Status changed from Reporter Feedback to Resolved

The files have been renamed as requested. These and the previous renames are collected in the changeset https://github.com/cuny-academic-commons/cac/commit/6507e8bb4d961305e90edd68ec9b3dbf122f5011

The stylesheet has been updated in our repo and will be deployed in the next hour or so, as part of the 1.10.2 release. https://github.com/cuny-academic-commons/cac/commit/22cfa864d65b92854ade9b9047f8a317cbe43866

I'm going to close this ticket in order to clear out my milestone. If you have further issues, please open a new ticket. Thanks.

#11 Updated by Ben Miller almost 3 years ago

Thanks, Boone! We owe you!

Also available in: Atom PDF