Project

General

Profile

Actions

Bug #6746

closed

Bug #6731: Out-of-control queries on production server

bp-multiple-forum-post activity "backfilling" is sometimes causing infinite query loop

Added by Boone Gorges about 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority name:
High
Assignee:
Daniel Jones
Category name:
Group Forums
Target version:
Start date:
2016-11-15
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

See attached log.

I have a gut feeling that this may be at the root of #6731, because (a) significant changes to bp-multiple-forum-post were included in the 1.10.1 release, and (b) the pattern of use of this plugin's features is such that I can easily imagine a few people cross-posting at the same time, and bringing things to a screeching halt.

Dan, I've had a brief look at the logic here, and nothing jumped out at me as obviously wrong. I also tried reproducing the issue in both a local environment and on cdev, but I couldn't force the backfiller logic to break. That said, I remember that when I wrote the original version of this logic for bp-event-organiser, I tore my hair out about recursion, and I remember that you tore some of your own out as well during the process of porting it over :)

For the time being, I have commented out the block that's responsible for the backfill on the production site (the block that begins "if ($removed)"...). If my gut feeling is correct, this will fix the problem. We should know more after another day or two.

Could you please have a look? In particular, look over the following changesets, and see whether the logic (or load order?) inadvertently changed:
- https://github.com/cuny-academic-commons/cac/commit/57c83f7807bda6b374fb0397657419fc29f79b07
- https://github.com/cuny-academic-commons/cac/commit/162852233193a276771b28ccdc117f1c163b7a08
- https://github.com/cuny-academic-commons/cac/commit/ca162ca086db0477297be04d72bff74f91693094

Thank you!


Files

bp-multiple-forum-post.txt (3.04 MB) bp-multiple-forum-post.txt Boone Gorges, 2016-11-15 09:57 PM

Related issues

Related to CUNY Academic Commons - Bug #10706: bp-multiple-forum-post triggers query loop on AJAX heartbeatResolvedBoone Gorges2018-11-15

Actions
Actions

Also available in: Atom PDF