Project

General

Profile

Actions
Copy link

Support #7340

closed

Modifying the Iframe content in JITP =>I-Lit piece

Added by Stephen Klein over 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Boone Gorges
Category name:
-
Target version:
1.10.14
Start date:
2017-01-06
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Similar to:
https://redmine.gc.cuny.edu/issues/6752
https://redmine.gc.cuny.edu/issues/5792

Can you modify the iframe here:
https://jitp.commons.gc.cuny.edu/i-lit/

Rather than pointing to:
https://ilit.altscholarship.com/
We would like to have the files installed locally. Here is a static zip of the site:
http://ldv1.gc.cuny.edu/~sklein/I_Lit/I-Lit/ilit.altscholarship.com/index.html

Actions
Copy link
 #1

Updated by Boone Gorges over 7 years ago

  • Status changed from New to Reporter Feedback
  • Target version set to 1.10.7

Sure, I can do this.

http://ldv1.gc.cuny.edu/~sklein/I_Lit/I-Lit/ilit.altscholarship.com/index.html points to the index page, rather than a zip. Can you easily provide a zip? It's much easier for me to work with.

Actions
Copy link
 #2

Updated by Stephen Klein over 7 years ago

Sorry, moving to fast. The previous link was for folks to view it.

Here is the zip:
http://library.gc.cuny.edu/aleph/I_lit.zip

Thanks,
Stephen

Actions
Copy link
 #3

Updated by Boone Gorges over 7 years ago

Thanks. Can you verify that the contents of the I-Lit/ilit.altscholarship.com directory are what you want to power the iframe? It looks like the rest of the stuff is unrelated.

Actions
Copy link
 #4

Updated by Stephen Klein over 7 years ago

I used HT Track to capture the content:
https://www.httrack.com/

, so I am not sure what was scope or not.

Maybe we need to see if they creators could send us a copy. I will email editors.

Stay tuned.

Thanks.

Actions
Copy link
 #5

Updated by Boone Gorges over 7 years ago

  • Target version changed from 1.10.7 to 1.10.8
Actions
Copy link
 #6

Updated by Boone Gorges about 7 years ago

  • Target version changed from 1.10.8 to 1.10.9
Actions
Copy link
 #7

Updated by Stephen Klein about 7 years ago

Sorry for the delay on this. Waiting for the editors to forward me a static capture of the site. Thanks.

Actions
Copy link
 #8

Updated by Boone Gorges about 7 years ago

  • Target version changed from 1.10.9 to 1.10.10
Actions
Copy link
 #9

Updated by Stephen Klein about 7 years ago

Earlier in the week, the managing editor (Laura) asked the issue editor (Amanda) for an update on this content. I have not heard back from either.

Actions
Copy link
 #10

Updated by Boone Gorges about 7 years ago

  • Target version changed from 1.10.10 to 1.10.11
Actions
Copy link
 #11

Updated by Boone Gorges about 7 years ago

  • Target version changed from 1.10.11 to 1.10.12
Actions
Copy link
 #12

Updated by Boone Gorges about 7 years ago

  • Target version changed from 1.10.12 to 1.10.13
Actions
Copy link
 #13

Updated by Boone Gorges about 7 years ago

  • Target version changed from 1.10.13 to Future release
Actions
Copy link
 #14

Updated by Stephen Klein about 7 years ago

Hi Boone,

I received approval from Laura to use:
http://library.gc.cuny.edu/aleph/I_lit.zip
Here it is live:
http://ldv1.gc.cuny.edu/~sklein/I_Lit/I-Lit/ilit.altscholarship.com/index.html

Can you set it up for:
https://jitp.commons.gc.cuny.edu/i-lit/

Please let me know if you need any info.

Thanks,
Stephen

Actions
Copy link
 #15

Updated by Boone Gorges about 7 years ago

  • Status changed from Reporter Feedback to Resolved
  • Target version changed from Future release to 1.10.14

Thanks, Stephen. In https://github.com/cuny-academic-commons/cac/commit/d7449feab18ed83f45679414eefaf6a326555703, I added the contents of the zip's subfolder I-Lit/ilit.altscholarship.com to the Commons, and modified the [jitp-ilit] shortcode so that it points to the local version rather than the remote one. No action should be necessary on the JITP site for these changes to take effect - it should be automatic after tomorrow's release.

For my own records: The structure of the i-lit subdirectories required me to modify the rewrite rule that we use for controlling access to non-public uploaded files https://github.com/cuny-academic-commons/cac/commit/49ff3e0e996648f27de0802cad6855e25fc2a9ac I've been meaning to fix this for some time anyway.

Actions
Copy link
 #16

Updated by Stephen Klein about 7 years ago

Thanks, Boone.
BTW, those commit URLs do not work.

Actions
Copy link
 #17

Updated by Boone Gorges about 7 years ago

The links are to a private repo, and are intended for internal record-keeping. Sorry for the inconvenience.

Actions
Copy link
 #18

Updated by Stephen Klein about 7 years ago

absolutely not an inconvenience! You are helping us, so we are inconveniencing you.

Actions
Copy link

Also available in: Atom PDF