Design/UX #8290
closed
Problems with Commons profile on mobile view
Added by Matt Gold over 7 years ago.
Updated over 7 years ago.
Category name:
Public Portfolio
Description
Hi All,
I noticed some responsiveness issues when viewing my Commons profile on my mobile phone (an iPhone). Here is what I noted:
-- areas of overlapping content
-- when one starts to scroll and the header snaps up, there are two issues -- 1. it snaps up before one can view all of the text in the header; and 2. In the snapped-up state (sorry -- that's probably not that right term, but I don't know what is), the header takes up more room than it should.
Please see attached screenshots. I know we are hoping to do a redesign, but I'm hoping that we can address at least a few of these issues in the short term before then.
Files
- Assignee changed from Boone Gorges to Daniel Jones
- Target version set to 1.11.4
Thanks for the ticket and the screenshots, Matt. We can definitely fix these items.
Dan, can I ask you to take a look? You may need to touch the JS to fix the "snap" point - see https://github.com/cuny-academic-commons/cac-advanced-profiles/blob/master/assets/js/cacap.js#L55 You should feel free to be liberal in making changes to the appearance of the header in narrow viewers; font size and padding look like they could use some adjustment as well.
Looks like you've already got push access to the repo - feel free to make your changes in a separate branch and then do a PR to master if you'd like a review from me before merging.
- Target version changed from 1.11.4 to 1.11.5
- Target version changed from 1.11.5 to 1.11.6
Thanks, Dan! I've applied the changes and they're looking pretty good in my testing.
The minified stylesheet in the plugin is due to the fact that the .css file is generated from the corresponding file in the /assets/sass directory. Do you mind porting your changes to the SASS stylesheet so that they're not lost? (I usually use Compass for SASS processing, but whatever tool you have is OK.)
- Status changed from Assigned to Resolved
No embarrassment or apologies necessary! Thanks so much for making the changes. I'll mark this resolved.
- Related to Bug #8463: Continued issues with portfolio view on mobile device added
Also available in: Atom
PDF