CUNY Academic Commons

Hi Dan - Following up on your email here for posterity.

I think I identified two stumbling blocks in getting the avatar JS to work during registration.

1. The Backbone templates (the skeleton HTML markup that Backbone uses to build its elements) were not being loaded into the DOM. https://github.com/cuny-academic-commons/cac/commit/657b30dbca85b0ab557f611f092fd9a25c104201
2. Once the templates were loaded, the script was throwing another error because of an empty bp_params property in the script params. I've forced them to be non-empty during registration: https://github.com/cuny-academic-commons/cac/commit/7b492e4c5702baba31b4b4c71b29c19fa5b04498

I got as far as opening the file browser. Avatar uploads don't work, but I assume that this is because BP doesn't know where to store them (since the user ID is 0). Back to you :)

For the record, I don't think we should go to much trouble to support the non-Backbone versions of this for the time being. This requires multiple pageloads for cropping, which is going to be a nightmare. So I think that stuff like bp_core_add_jquery_cropper() will not be necessary, but I'll leave that for you to figure out.

Dan, could you let us know where this issue stands? Do you have a work in progress you could easily share? If there's something I could do to help get this across the finish line in the next three or four days, I'd be glad to do my best. Thanks in advance.

Sorry, Boone - I've made some progress here, but not enough.

I've pushed some changes to a branch here: https://github.com/cuny-academic-commons/cac/commit/79b03cc65889d0b655f4aabb22e480bf4b7a15b1

I've figured out a bunch of errors and have the avatar file successfully uploading to a temporary folder (ends up being blogs.dir/1/avatars/0). Note though, that I had to add a couple of action hooks to BuddyPress itself to allow the bp_avatar_upload and bp_avatar_set functions to run for a non-logged-in user. Not sure if there's a better way to handle that.

What I was about to start working on is how this all plays out when the user actually hits the submit button - if you could point me in the right direction on that, it'd be great. There's also some stying issues that need to get worked out.

Thanks, Dan. Can you please try to cobble together some workable styling? I'll see if I can duct tape something for the server-side handling in the next day.

Scratch that request, Dan. I had a look myself.

Ray, could I ask for you to do a sanity check on this, before I pass it along to the team for testing? No need for a code review (unless you want to know the awful details of what has to happen for this to work). Just pull the bp-avatar-on-register branch from GitHub and run it through a few local tests.

Hmm, I'm not able to successfully upload an image.

I get a generic "An error occurred. Please try again later." message after attempting to select a file for uploading. The AJAX call gives me a JSON object with success: false.

Blurg. Back to the drawing board. Thanks for looking.

I just pulled into 1.12 and tried on LDV1, where it appears to be working.

Ray, it's possible that you have some permissions issues that make it impossible for the plugin to create the [upload_dir]/signup-avatars directory. Maybe try creating it manually (it'll live next to BP's avatars and group-avatars directories). Probably not worth a lot of bother, though, if it's working on the Commons setup :)

Could I still ask you to give it one run through on LDV1, though? I want to be sure I don't hand something totally broken to the gang. Thank you sir!

I think the issue could be with my Chromium 63 setup.

Works in Firefox 56.

Cool, thanks, Ray. If it's a browser-specific issue, it could be something that I could debug with console output - if you get a chance to take a screenshot of the request payload and response, that'd be helpful.

This worked for me using Safari on my Mac.