Support #10180: domain mapping request - Kelle Cruz - CUNY Academic Commons - CUNY Graduate Center - Project Tracking System

Custom queries

. 2.3.7 open
2.4.0 open
2.4.0 open (by category)
2.4.0 open (by tracker)
High Priority Issues by User
Inbox (no milestone)
My Assigned Issues (by milestone)
My Watched Issues (by milestone)
Not Tracked - grouped by assignee
Not tracked (milestone-independent)

Actions

Copy link

Support #10180

closed

domain mapping request - Kelle Cruz

Added by scott voth over 5 years ago. Updated over 5 years ago.

Status:

Resolved

Priority name:

Normal

Assignee:

Matt Gold

Category name:

Domain Mapping

Target version:

1.13.8

Start date:

2018-08-20

Due date:

% Done:

Estimated time:

Deployment actions:

Description

Please map Commons site: https://cunyastro.commons.gc.cuny.edu/ to: cunyastro.org.

Kelle is ready to make changes on her side.

History
Notes

Actions

Copy link

Updated by Boone Gorges over 5 years ago

Assignee set to Matt Gold
Target version set to Not tracked

Matt, let me know when IT has made the change.

It looks like the DNS changes have not been made to cunyastro.org. Since the domain doesn't point to an existing site, I'd suggest that the DNS change be made right away, so that when we've made the changes on the Commons, we'll be able to switch over right away.

Actions

Copy link

Updated by scott voth over 5 years ago

Kelle says she has made the changes.

Actions

Copy link

Updated by Matt Gold over 5 years ago

Hi Scott -- do we have any other domain mapping requests pending at the moment? Maybe one for the CGEP site? I'd like to send only one message if possible.

Actions

Copy link

Updated by scott voth over 5 years ago

There will be one for CGEP - but I don't think Fred Meyer has created a site on the Commons yet. I don't know of any others.

Actions

Copy link

Updated by Matt Gold over 5 years ago

Okay -- thanks, Scott. I've submitted the request and will report back

Actions

Copy link

Updated by Matt Gold over 5 years ago

this is done

Actions

Copy link

Updated by Boone Gorges over 5 years ago

Status changed from New to Resolved

Thanks, all. Domain mapping is complete.

CCing Ray as an FYI: The mapping broke the custom header. The header image, as set in the Customizer, has the URL https://cunyastro.commons. get_header_image() runs through set_url_scheme(), which on the front-end means that the URL was rewritten as http://cunyastro.commons, and the browser (my browser, at least) wasn't doing the necessary redirect. As a temporary workaround, I've changed the theme mod so that the custom header URL has the mapped domain:

wp --url=cunyastro.commons.gc.cuny.edu theme mod set header_image http://cunyastro.org/wp-content/blogs.dir/3825/files/2018/08/banner2_24.jpg

This is fragile and would break if the user changes the header image again. But the issue should go away once we've got letsencrypt HTTPS for all mapped domains, which should happen in the next month or two.

Actions

Copy link

Updated by Raymond Hoh over 5 years ago

CCing Ray as an FYI: The mapping broke the custom header. The header image, as set in the Customizer, has the URL https://cunyastro.commons. get_header_image() runs through set_url_scheme(), which on the front-end means that the URL was rewritten as http://cunyastro.commons, and the browser (my browser, at least) wasn't doing the necessary redirect.

I wrote some code awhile back to dynamically switch out the mapped domain for the subdomain for certain theme mods such as 'theme_mod_header_image':
https://github.com/cuny-academic-commons/cac/commit/93abbffbc28237820783a088908fbb088b779fd0

Probably lines 303-304 need adjusting. Maybe force HTTPS?

Actions

Copy link

Updated by Boone Gorges over 5 years ago

Thanks, Ray! Yes, I think that forcing HTTPS when swapping the mapped domain for the subsite domain is probably correct, since we force HTTPS on *.commons.gc.cuny.edu.

Actions

Copy link

#10