CUNY Academic Commons

Eek, thanks for finding this bug.

I'm about to push a commit for this.

Oops, cross-post. Thanks Ray!

I've added a fix to skip the non-RBE notice injection into registration with blog and email change emails - https://github.com/cuny-academic-commons/cac/commit/c98b1886a825db221e011729b913e2c8a37503d3

I've tested by changing my email address on the "Settings > General" page and the email content now successfully renders.

#10260 appears to be a different bug. I'm looking into this.

Thanks, Ray. This is the second or third time I've come across a similar issue in RBE since some changes in BP 3.0. Just spitballing, but do you think there's something that BP could do with its default templates to make this kind of strpos juggling unnecessary? Like what if the template included HTML comments that served as landmarks (sorta like WP actions) - something like <!-- bp.start_of_message --> - so that you could use this when moving your markers around?

It's not a RBE problem. The stripping of the "Hi USER" salutation from BP HTML emails is a CAC customization.

One of my other thoughts was to override the BP email HTML template to remove the salutation. However, the salutation is used in GES digests and you can't use conditionals in the email template. Update - Actually, I think BP has an email template hierarchy, so this could be potentially done.

Although the usage of HTML comments to denote certain sections in the BP HTML email template sounds like a good idea in general.

It's not a RBE problem. The stripping of the "Hi USER" salutation from BP HTML emails is a CAC customization.

I'm referring to the fact that RBE has to use string manipulation to figure out where to put its marker. It's not so much that it's an RBE "problem", it's that RBE has come up with the only possible workaround to the fact that email templates are unstructured entities.

A custom email template in our theme seems like it may be a good idea.

Yes, RBE has to rely on HTML source manipulation to re-position the marker, but that isn't the cause of this Redmine issue.

The cause of this issue is due to the changes to the BP HTML email template and the stripping of the "Hi USER" salutation, which also happens to use string manipulation. I was previously attempting to strip a trailing <br> after the <hr />, but that doesn't seem to be necessary any more in the latest BP HTML email template.

RBE doesn't strip the "Hi User" salutation, CAC does. I don't think it's necessary to override the BP HTML email template at this time as there shouldn't be any more problems going forward, unless there are more changes done to the salutation markup in the future.

I see. Sort of :)

I had one or two client sites experience some ugly issues after upgrading to BP 3.0 because of the RBE parsing, so I guess I was thinking that maybe there was the possibility of a longer-term fix. But I have put much less thought into this than you have, so I'm happy to go with whatever solution you think best!

After looking at this a little closely, I do see now that RBE is aggressively removing the marker plus the trailing <br /> and whitespace after the salutation!

So RBE is somewhat at fault here. Although, this problem would only occur if your client sites have customized the main body of the BP HTML email template.

I'll create an issue over at the RBE repo to track this.