CUNY Academic Commons

Thanks, Gina. This is helpful.

Ray, could you please take a look to see if unspamming triggers double-notifications?

I was able to replicate this on cdev.

The duplicate problem occurs when recording non-member blog comments into the group activity stream. Recording blog comments into the group activity stream was implemented as part of the BP Groupblog plugin in #8225.

The issue here is another plugin, bp-include-non-member-comments, first records non-member blog comments into the activity stream. BP Groupblog then modifies this activity item so it is recorded into the group activity stream. Both save attempts triggers the BP Group Email Subscription plugin to record the same item into the wp_bpges_queued_item DB table.

Here's a quick backtrace:

// First save
do_action('wp_ajax_dim-comment'), WP_Hook->do_action, WP_Hook->apply_filters, call_user_func_array, wp_ajax_dim_comment, wp_set_comment_status, do_action('wp_set_comment_status'), WP_Hook->do_action, WP_Hook->apply_filters, call_user_func_array, bp_blogs_record_nonmember_comment_approved, bp_blogs_record_nonmember_comment, bp_blogs_record_activity, bp_activity_add, BP_Activity_Activity->save, do_action_ref_array, WP_Hook->do_action, WP_Hook->apply_filters, call_user_func_array, ass_group_notification_activity

// Second save
do_action('wp_ajax_dim-comment'), WP_Hook->do_action, WP_Hook->apply_filters, call_user_func_array, wp_ajax_dim_comment, wp_set_comment_status, wp_transition_comment_status, do_action('transition_comment_status'), WP_Hook->do_action, WP_Hook->apply_filters, call_user_func_array, bp_activity_transition_post_type_comment_status, BP_Activity_Activity->save, do_action_ref_array, WP_Hook->do_action, WP_Hook->apply_filters, call_user_func_array, ass_group_notification_activity

I decided to fix this in BPGES to ignore duplicate entries from being recorded here.

The alternative is patching bp-groupblog to bail out of bp_groupblog_transition_comment_status if the comment is anonymous and if bp-include-non-member-comments is active:
https://github.com/boonebgorges/bp-groupblog/blob/master/bp-groupblog.php#L1448

This might not be 100% foolproof, so I decided to go with the BPGES fix.

Boone, let me know what you think of the approach.

Added as a hotfix here - https://github.com/cuny-academic-commons/cac/commit/b6969b875ad3e1f3a7a5b10bcb601d6558fe782c

- Ran ALTER TABLE wp_bpges_queued_items DROP INDEX group_id
- Attempted to run wp bpges install-database. But this returned some DB errors because of existing duplicate entries in the DB table.

WordPress database error Duplicate entry '{user_id}-{group_id}-{activity_id}-{type}' for key 'user_group_activity_type' for query ALTER TABLE wp_bpges_queued_items ADD UNIQUE KEY `user_group_activity_type` (`user_id`,`group_id`,`activity_id`,`type`) made by include('phar:///usr/local/bin/wp/php/boot-phar.php'), include('phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/wp-cli.php'), WP_CLI\bootstrap, WP_CLI\Bootstrap\LaunchRunner->process, WP_CLI\Runner->start, WP_CLI\Runner->_run_command_and_exit, WP_CLI\Runner->run_command, WP_CLI\Dispatcher\Subcommand->invoke, call_user_func, WP_CLI\Dispatcher\CommandFactory::WP_CLI\Dispatcher\{closure}, call_user_func, BPGES_Command->install_database, bpges_install_queued_items_table, dbDelta

Next, I removed all the duplicates with DELETE FROM wp_bpges_queued_items WHERE id = X. After removing all the duplicate entries, the CLI command finally worked and the indexes have been updated:

wp db query 'SHOW INDEX FROM wp_bpges_queued_items'
+-----------------------+------------+--------------------------+--------------+---------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
| Table                 | Non_unique | Key_name                 | Seq_in_index | Column_name   | Collation | Cardinality | Sub_part | Packed | Null | Index_type | Comment | Index_comment |
+-----------------------+------------+--------------------------+--------------+---------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
| wp_bpges_queued_items |          0 | PRIMARY                  |            1 | id            | A         |        3204 |     NULL | NULL   |      | BTREE      |         |               |
| wp_bpges_queued_items |          0 | user_group_activity_type |            1 | user_id       | A         |        3204 |     NULL | NULL   |      | BTREE      |         |               |
| wp_bpges_queued_items |          0 | user_group_activity_type |            2 | group_id      | A         |        3204 |     NULL | NULL   |      | BTREE      |         |               |
| wp_bpges_queued_items |          0 | user_group_activity_type |            3 | activity_id   | A         |        3204 |     NULL | NULL   |      | BTREE      |         |               |
| wp_bpges_queued_items |          0 | user_group_activity_type |            4 | type          | A         |        3204 |     NULL | NULL   |      | BTREE      |         |               |
| wp_bpges_queued_items |          1 | user_id                  |            1 | user_id       | A         |        3204 |     NULL | NULL   |      | BTREE      |         |               |
| wp_bpges_queued_items |          1 | activity_id              |            1 | activity_id   | A         |         534 |     NULL | NULL   |      | BTREE      |         |               |
| wp_bpges_queued_items |          1 | user_group_type_date     |            1 | user_id       | A         |        3204 |     NULL | NULL   |      | BTREE      |         |               |
| wp_bpges_queued_items |          1 | user_group_type_date     |            2 | type          | A         |        3204 |     NULL | NULL   |      | BTREE      |         |               |
| wp_bpges_queued_items |          1 | user_group_type_date     |            3 | date_recorded | A         |        3204 |     NULL | NULL   |      | BTREE      |         |               |
| wp_bpges_queued_items |          1 | group_id                 |            1 | group_id      | A         |         110 |     NULL | NULL   |      | BTREE      |         |               |
+-----------------------+------------+--------------------------+--------------+---------------+-----------+-------------+----------+--------+------+------------+---------+---------------+