Project

General

Profile

Bug #11388

Rewrite member search queries

Added by Boone Gorges about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
BuddyPress (misc)
Target version:
Start date:
2019-04-23
Due date:
% Done:

0%

Estimated time:

Description

Member search queries should not touch last_activity in usermeta, as we're no longer mirroring it. See #11209, #10687.


Related issues

Related to CUNY Academic Commons - Feature #10687: Stop mirroring BP last_activity to usermetaResolved2018-11-08

Related to CUNY Academic Commons - Bug #11209: Activity timestamp errorsResolved2019-03-11

History

#1 Updated by Boone Gorges about 3 years ago

Ray, I've assigned this to you - I think it's just a quick change in the JOIN in bp-better-directories. If it ends up being more complex and you don't want to deal with my mess, assign back to me :)

#2 Updated by Boone Gorges about 3 years ago

also feel free to put into 1.15 - there will not be another release in the 1.14.x series.

#3 Updated by Boone Gorges about 3 years ago

  • Related to Feature #10687: Stop mirroring BP last_activity to usermeta added

#4 Updated by Boone Gorges about 3 years ago

  • Related to Bug #11209: Activity timestamp errors added

#5 Updated by Raymond Hoh about 3 years ago

  • Category name set to BuddyPress (misc)
  • Status changed from New to Staged for Production Release
  • Target version changed from 1.15.1 to 1.15

Boone, I've rewritten bp-better-directories to use BP_User_Query here - https://github.com/cuny-academic-commons/cac/compare/fdb03c4...c6b1e14

I was going to add a PR to the bp-better-directories repo with my changes and found out that the code on the GitHub repo is different than on CAC:
https://github.com/boonebgorges/bp-better-directories/blob/1.0.x/bpbd.php#L13
https://github.com/cuny-academic-commons/cac/blob/1.15.x/wp-content/plugins/bp-better-directories/bpbd.php#L15

The code on Github seems to be newer and supports additional things like custom templates, but I used a slightly different approach in constructing the query.

I'm guessing the one we use on CAC is specialized to bp-nelo / bp-default. Anyway, let me know if you want me to send a PR.

#6 Updated by Boone Gorges about 3 years ago

  • Status changed from Staged for Production Release to Resolved

#7 Updated by Boone Gorges about 3 years ago

Thanks, Ray! I don't think it's necessary to send a PR - no one is using that plugin :)

Also available in: Atom PDF