Bug #11388: Rewrite member search queries - CUNY Academic Commons - CUNY Graduate Center - Project Tracking System

Custom queries

. 2.4.3 open
2.5.0 open
2.5.0 open (by category)
2.5.0 open (by tracker)
High Priority Issues by User
Inbox (no milestone)
My Assigned Issues (by milestone)
My Watched Issues (by milestone)
Not Tracked - grouped by assignee
Not tracked (milestone-independent)

Actions

Copy link

Bug #11388

closed

Rewrite member search queries

Added by Boone Gorges about 5 years ago. Updated about 5 years ago.

Status:

Resolved

Priority name:

Normal

Assignee:

Raymond Hoh

Category name:

BuddyPress (misc)

Target version:

1.15

Start date:

2019-04-23

Due date:

% Done:

Estimated time:

Deployment actions:

Description

Member search queries should not touch last_activity in usermeta, as we're no longer mirroring it. See #11209, #10687.

Related issues

Related to CUNY Academic Commons - Feature #10687: Stop mirroring BP last_activity to usermeta

Resolved

Boone Gorges

2018-11-08

Actions

Related to CUNY Academic Commons - Bug #11209: Activity timestamp errors

Resolved

Raymond Hoh

2019-03-11

Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by Boone Gorges about 5 years ago

Ray, I've assigned this to you - I think it's just a quick change in the JOIN in bp-better-directories. If it ends up being more complex and you don't want to deal with my mess, assign back to me :)

Actions

Copy link

Updated by Boone Gorges about 5 years ago

also feel free to put into 1.15 - there will not be another release in the 1.14.x series.

Actions

Copy link

Updated by Boone Gorges about 5 years ago

Related to Feature #10687: Stop mirroring BP last_activity to usermeta added

Actions

Copy link

Updated by Boone Gorges about 5 years ago

Related to Bug #11209: Activity timestamp errors added

Actions

Copy link

Updated by Raymond Hoh about 5 years ago

Category name set to BuddyPress (misc)
Status changed from New to Staged for Production Release
Target version changed from 1.15.1 to 1.15

Boone, I've rewritten bp-better-directories to use BP_User_Query here - https://github.com/cuny-academic-commons/cac/compare/fdb03c4...c6b1e14

I was going to add a PR to the bp-better-directories repo with my changes and found out that the code on the GitHub repo is different than on CAC:
https://github.com/boonebgorges/bp-better-directories/blob/1.0.x/bpbd.php#L13
https://github.com/cuny-academic-commons/cac/blob/1.15.x/wp-content/plugins/bp-better-directories/bpbd.php#L15

The code on Github seems to be newer and supports additional things like custom templates, but I used a slightly different approach in constructing the query.

I'm guessing the one we use on CAC is specialized to bp-nelo / bp-default. Anyway, let me know if you want me to send a PR.

Actions

Copy link