Bug #11506
closed
Home Page Slideshow - blank slide
Added by scott voth about 5 years ago.
Updated about 5 years ago.
Category name:
Homepage Slides
Description
Hero slideshow seems to have a blank slide at the beginning:
<img alt='css.php' src="https://commons.gc.cuny.edu/wp-content/plugins/cookies-for-comments/css.php?k=56432b1df3e67e3f4dcdbad943087b&o=i&t=224126708" width='1' height='1' /> <div class="slide first_slide">
- Status changed from New to Assigned
- Assignee changed from scott voth to Raymond Hoh
- Target version set to 1.15.3
Good catch, Boone.
The main query limitation was something I considered, but thought it would be better to open up the restriction so the Cookies for Comments asset had a better chance of being rendered before the footer.
Currently, if you check the Cookies for Comments asset on the historyprogram.commons.gc.cuny.edu
site (the site referenced in #11453), the asset is now loaded in the footer instead of before.
Maybe, instead, I can check the post type and bail if the post type matches 'slide'
?
I'd considered the 'slide' blacklist, but it seems like this leaves us open to whack-a-mole for other similar problems.
That being said, this is a very specific problem to the homepage slider plugin, which parses body content for img tags. This is very unusual, and is unlikely to arise in many other cases. So maybe the blacklist is OK.
Happy to go with whatever you think best.
- Target version changed from 1.15.3 to 1.15.4
- Target version changed from 1.15.4 to 1.15.5
- Status changed from Assigned to Resolved
Let's mark this as resolved for now.
Also available in: Atom
PDF