Project

General

Profile

Actions

Bug #11810

closed

HTML presenting on front end

Added by Kristen Hackett over 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
-
Target version:
Start date:
2019-08-29
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Hello,

I am submitting a ticket on behalf of the Digital Fellows site: https://digitalfellows.commons.gc.cuny.edu/

Since yesterday afternoon, we have noticed HTML presenting on the front end of the site. We have not recently added plugins or changed the theme, so we are not sure what the issue is. Could you please advise.

Thank you!
Kristen


Files


Related issues

Related to CUNY Academic Commons - Support #13923: Request to update Dante themeResolvedRaymond Hoh2021-02-01

Actions
Actions #1

Updated by Stefano Morello over 4 years ago

Thank you for submitting this, Kristen – the other thing we noticed is that the header of the site now shows the logo of the Theme rather than the title of the website.

Actions #2

Updated by Boone Gorges over 4 years ago

  • Status changed from New to Reporter Feedback
  • Assignee set to Boone Gorges
  • Target version set to 1.15.9

Thanks for the report, and sorry for the troubles.

On Tuesday morning, I deployed one of our twice-monthly scheduled updates to themes and plugins on the site. See https://dev.commons.gc.cuny.edu/release-schedule-and-procedures/ for more info. This release included an update to the Dante theme. This update to the Dante theme included some major changes, where much of the theme's functionality was moved into a required standalone plugin (Dante Framework) as well as a required utility plugin from the wordpress.org repo (Meta Box). I didn't know that these changes were happening, so I didn't add the plugins as part of the release. And even if I'd added them, they would've needed some manual intervention (plugin activation, at least; see below) in order for the sites to work properly.

I've added the plugins and deployed them to the production site:
- dante-framework https://github.com/cuny-academic-commons/cac/commit/81e4b71a93f1ea6c32b11e8c85e5b56a9e5299e0
- meta-box https://github.com/cuny-academic-commons/cac/commit/a0fc413a2e625fba4d6fee0a5b0d085df9479f6c

I activated the plugin on digitalfellows.commons.gc.cuny.edu. This appears to have addressed the unrendered shortcodes ("HTML presenting") and other layout issues.

The 'Dante' logo is still present in the header. I did a brief examination of the changes in the recent version of Dante, and as far as I can see, the header functionality was totally rewritten. It now expects there to be a logo - there doesn't appear to be a way to disable the logo, in favor of showing a text version of the site title. (I could be wrong about this - please feel free to look through the theme settings to see if I'm overlooking someone.) As such, it may be necessary for you to upload a logo, if only an image containing the text 'GC Digital Fellows'. Could I ask your team to look through this and let me know whether I'm missing something?

I scanned the Commons for other themes running Dante and ran a command to activate the plugins there as well:

wp --url=2015lacunyinst.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=asaminnyc.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=bacchustemple.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=buildingaas.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=clara.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=cvdh4.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=digitalfellows.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=fashionmock3.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=imendel000.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=imendelwfe.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=importantsite.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=javo01.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=kallewesterling.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=katiahenrys.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=kccenglish.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=laurakane.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=locus.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=miniguide.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=momentsthings.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=pcpdev.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=psrg.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=tarquinia.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=templeofbacchus.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=testasamsummer.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=testingmals.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=vianny.commons.gc.cuny.edu plugin activate dante-framework meta-box && wp --url=videomock.commons.gc.cuny.edu plugin activate dante-framework meta-box

Aside from the specifics of this update, there's a more general question about how to avoid these sorts of problems in the future. These kinds of massive changes between theme and plugin versions, especially those that require manual intervention from end users, are uncommon, but not unheard of. The Commons has many dozens of available themes and hundreds of available plugins, and so it's impossible for us to do a deep examination and testing of changelogs for each update. (Changes in a theme like Dante are even harder to track because it's a commercial theme purchased through ThemeForest.) Our team will take every reasonable effort to learn in advance about important changes in plugins/themes, especially those that are most widely used on the Commons; and when we know about these changes in advance, we'll do our best to automate the update/migration process for end users. But we must depend for this process on the cooperation of "hosting partners", who are the best equipped to understand when major changes to Commons software will directly affect the specific way in which their site works. See https://dev.commons.gc.cuny.edu/hosting-partner-handbook/ for more info, and especially the "Proprietary..." section. But the gist is: hosting partners should, if possible, keep an eye on upcoming updates as announced at https://dev.commons.gc.cuny.edu; test upcoming changes that are critical to site operation in your own development/staging environments, particularly in the case of proprietary tools; report issues to the Commons team, ideally before the scheduled release, but afterward (like in this ticket!) is also good. I realize that many hosting partners are not staffed with the kind of resources and expertise to do all of this in advance, so it's likely that we'll sometimes have cases like this one where the issue is not identified until after the problem has cropped up. This is probably the best we can do, and I think you in advance for your patience as we work through it together.

Actions #3

Updated by Matt Gold over 4 years ago

Thanks for your careful work on this, Boone.

Actions #4

Updated by Kristen Hackett over 4 years ago

Boone, many thanks for this thorough report, we really appreciate your time and attention. We'll be sure to check the handbook for better protocols we might implement in the future; and perhaps we'll be considering a theme change.

Like you, I am seeing few options to remove the theme name from the site and replace it with "GC Digital Fellows", though an image clumsily does accomplish this. Our team can decide what we want to do about that.

Many thanks again!
kristen

Actions #5

Updated by Boone Gorges over 4 years ago

  • Status changed from Reporter Feedback to Resolved

Thanks, Kristen!

Actions #6

Updated by Stefano Morello about 4 years ago

Boone Gorges wrote:

Thanks, Kristen!

Hi Boone! Just reporting that the issue is occurring again on the same website. It's happening in most pages (e.g., https://digitalfellows.commons.gc.cuny.edu/about/ ; https://digitalfellows.commons.gc.cuny.edu/ ), but it doesn't seem to be an issue with posts ( e.g., https://digitalfellows.commons.gc.cuny.edu/2019/09/19/how-to-get-the-most-out-of-office-hours/)

Perhaps this time it has something to do with either an outdated plugin (LayerSlider WP), or, some other issue with the Dante theme, following the latest maintenance update?

Actions #7

Updated by Raymond Hoh about 4 years ago

Hi Stefano,

The problem was caused in an attempt to fix a theme-dependent plugin issue with the 'dante-framework' plugin in #12278.

I've relaxed the conditional clause. Can you check if everything is working? Especially the Dante theme options page or anything regarding Dante in the admin area?

Actions #8

Updated by Stefano Morello about 4 years ago

Raymond Hoh wrote:

Hi Stefano,

The problem was caused in an attempt to fix a theme-dependent plugin issue with the 'dante-framework' plugin in #12278.

I've relaxed the conditional clause. Can you check if everything is working? Especially the Dante theme options page or anything regarding Dante in the admin area?

Thank you for your prompt intervention on this, Ray. I took a quick look and it seems like everything is working well. I'll let you know if something else comes up.

Actions #9

Updated by Raymond Hoh about 3 years ago

Actions

Also available in: Atom PDF