CUNY Academic Commons

Thanks for the detailed report, Laurie.

I've just run through some tests with the Claim Key feature and I can confirm that it's generally working for both groups and sites. The fact that the users are, in fact, joined to the sites makes me think that it's working for them too. (If I had more details about the specific claim keys, users, sites, etc, I could verify, but perhaps this is unnecessary.)

The 'No invitation...' error is shown when the system cannot find a pending (ie, non-accepted and non-rejected) invitation corresponding to the claim key. My original thought was that this would only happen when inputting incorrect keys, in which case the 'No invitation...' error is appropriate. However, it'll also be shown if the claim key matches an already accepted invitation. I'm guessing this is what's happening here: the users click through the email the first time, register for the Commons (or accept the invitation directly via Claim Key, depending), and then go back to the email and click Claim again. In this case, 'No invitation...' is not an appropriate response - we should instead be showing a message along the lines of "You've already accepted this invitation". Let me take a look to see how hard this change would be, as maybe I can slip it into today's release.

I've made the change. At the time of claim, I'm now saving the "accepter ID". Then, when an invitation is claimed:

- if the user claiming is not the same as the user who has previously claimed the invitation, a generic "That invitation has already been accepted" error is shown.
- if the user is the user who has previously claimed (this should be the vast majority of cases), the success message is shown again. I opted for this because (a) it shows links to associated groups/sites, and (b) it reduces UX overhead for the user - they don't need to know that they've accepted a second time, just that the acceptance was successful.