CUNY Academic Commons

Ray, could you have a look? I don't know whether the problem is the markup (should it use em instead?) or the allowed tags.

Colin, how did you add the <span style="text-decoration:underline"> tag? There is no button to underline in the visual editor or code editor. Did you write it yourself in the code editor? Or did you press CTRL+U in the visual editor?

Technically, bbPress does not allow the <span> element to be rendered for regular users. Only super administrators can bypass this, but Colin's account isn't an administrator, so the underline shouldn't have even shown in the live preview.

However, if you used the CTRL+U approach, you would see the underline in the textarea, but not in the live preview. See attached screenshot. Maybe this is what you meant, Colin?

should it use em instead?

<em> is already used for italics by the bbPress I button.

If we want to allow underlining (and also bring back the underline button), we would have to enable the <span> element and also the style attribute in bbPress. Adding the style attribute would allow users to write any inline styles in their content. Is this something we want to allow?

Or we could write our own custom underline button with the following markup -- <span class="underline"> and enable the class attribute. This would allow underlining and we wouldn't have to open up inline styles.

(I don't often use it myself, but must have just been feeling adventurous that day...)

I was feeling adventurous so I decided to add the Underline button :)

The Underline button uses the following markup: <span class="bbp-underline">Test</span> instead of <span style="text-decoration:underline">Test</span>.

The button is available in both the Visual Editor or the Text Editor.

Commit - https://github.com/cuny-academic-commons/cac/commit/065efa6b19e4aa3d5730509a31eb4580fc52f382