Bug #14716: My Commons activity blank - CUNY Academic Commons - CUNY Graduate Center - Project Tracking System

Actions

Copy link

Bug #14716

closed

My Commons activity blank

Added by Colin McDonald over 3 years ago. Updated over 3 years ago.

Status:

Resolved

Priority name:

Normal

Assignee:

Raymond Hoh

Category name:

My Commons

Target version:

1.18.17

Start date:

2021-08-17

Due date:

% Done:

Estimated time:

Deployment actions:

Description

Hello, it seems that the My Commons streams may be acting up. When I first go there I can see All Activity, but toggling back and forth to Groups / Sites / etc I don't see anything (see attached), and I can't get back to All Activity being populated either. I just see the yellow error message. Sonja first noticed this, so it seems at to be at least somewhat widespread.

Files

Screen Shot 2021-08-17 at 3.52.19 PM.png (254 KB) Screen Shot 2021-08-17 at 3.52.19 PM.png

Colin McDonald, 2021-08-17 06:45 PM

Related issues

Actions

Copy link

Updated by Raymond Hoh over 3 years ago

Category name set to My Commons
Status changed from New to Assigned
Assignee changed from Boone Gorges to Raymond Hoh
Target version set to 1.18.17

I'm looking into this. Might be related to a recent change to BuddyPress.

Actions

Copy link

Updated by Raymond Hoh over 3 years ago

Related to Bug #13352: jQuery update for bp-nelo added

Actions

Copy link

Updated by Raymond Hoh over 3 years ago

Fixed in https://github.com/cuny-academic-commons/cac/commit/97da394f23571626e0cbe637c2cfa8fbbebb2322.

Issue is due in part to #13352. If you're interested in the cause, continue reading :)

When we switched out the older jQuery Cookie library for js-cookie, the bp_get_cookies() function needed to be rewritten to use js-cookie's logic. I made a previous attempt at addressing this in https://redmine.gc.cuny.edu/issues/13352#note-9, however this did not account for an edge-case where a non-existing value could be passed.

Specifically, the filter value here: https://github.com/cuny-academic-commons/cac/blob/ea215fb837088e4ad90f31e6422ade7446617e55/wp-content/themes/bp-nelo/_inc/global.js#L216. On the "My Commons" page, the activity dropdown filter is not rendered, so this value is undefined. The previous cookie logic already took this into account, but not the rewritten version.

Should be fixed now. This is added as a hotfix on production. You might need to refresh the "My Commons" page or purge your browser cache if the fix is not working.

Actions

Copy link