Bug #15136
closedMain menu nav items are incorrect
0%
Description
As noted in #15135, something happened in the 1.19 launch that caused the nav menu to be displayed incorrectly.
Updated by Boone Gorges almost 3 years ago
- Status changed from New to Resolved
I'm not sure why this happened, but I have fixed it.
In the case of Privacy Policy and Terms of Service, the links went to non-existent pages. I couldn't find evidence of the pages even in the trash. I'm not sure what happened here or why, so I restored the pages to what's found on cdev and added them into the About submenu where they appear on that site.
Updated by Colin McDonald almost 3 years ago
Thanks for working on this, Boone. I was just taking a look and those links seem good, but I clicked on the Image Credits and Contact Us links right next to them and both seem broken too. Credits gives a 403 errors, seems to want to redirect
https://commons.gc.cuny.edu/about/images
to
https://commons.gc.cuny.edu/images/
And for Contact Us, this is the broken link:
https://commons.gc.cuny.edu/about/contact-us
Maybe something on CDEV for these too?
Updated by Boone Gorges almost 3 years ago
"Image Credits" used to point to this page https://commons.gc.cuny.edu/images-credits/ but I'm unsure that it's relevant anymore, since we don't use the slider. I'm removing it from the menu.
Likewise, I don't see evidence of a 'Contact Us' page anywhere, and I don't recall one ever existing. I've removed it.
Updated by Matt Gold almost 3 years ago
Hi Boone -- I'd like to bring Scott into this conversation before removing image credits. We should be crediting people for the images we use. Scott, in the new setup, do you foresee ways that you will be using photos that need attribution?
Updated by Boone Gorges almost 3 years ago
The specific focus of that page was for slider images on the main site. We don't have a slider anymore.
Posts on the News site and elsewhere may have images, but it seems that the image credits should go in those posts instead.
Updated by scott voth almost 3 years ago
Yes, I think we could have a page on both the News site and the InCommon site for attributions. I usually put the attributions in the caption field of the images. However, it is not evident where the images are coming from when looking at home page.
Updated by Raymond Hoh almost 3 years ago
Just spotted that the sitewide footer still contained the "Contact Us" and "Image Credits" links. I've just removed them in https://github.com/cuny-academic-commons/cac/commit/661945ab6a4625ce67c2c221d7dbcfd6bd5ea3f0 and deployed the commit as a hotfix.