Project

General

Profile

Actions
Copy link

Bug #15196

closed

footer positioning on GCDI site

Added by Matt Gold almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Raymond Hoh
Category name:
Layout
Target version:
1.19.2
Start date:
2022-01-17
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Hi Ray and Boone,

I just noticed that the footer positioning on the GCDI site is a bit off, with the logo appearing above the black footer space - https://cdla.commons.gc.cuny.edu/ . Screenshot attached.

I'm not sure whether this is due to the CAC footer or our custom styles on the GCDI site. but, Ray, since you helped us with this site, would you mind taking a look? thanks so much in advance.

Files

Screen Shot 2022-01-17 at 4.54.34 PM.png (51.5 KB) Screen Shot 2022-01-17 at 4.54.34 PM.png Matt Gold, 2022-01-17 04:56 PM
Actions
Copy link
 #1

Updated by Raymond Hoh almost 3 years ago

  • Category name set to Layout
  • Status changed from Assigned to Staged for Production Release
  • Target version set to 1.19.2

I've added some inline CSS temporarily so the sitewide footer displays under any floated containers on the GCDI site.

Will be fixed in https://github.com/cuny-academic-commons/cac/commit/e3e183bdbc220a2d4b5df995bd82df26c523eebc.

Actions
Copy link
 #2

Updated by Matt Gold almost 3 years ago

Thank you!

Actions
Copy link
 #3

Updated by Boone Gorges almost 3 years ago

  • Status changed from Staged for Production Release to Resolved
Actions
Copy link

Also available in: Atom PDF