Bug #15219: Alignment with Rowling Theme - CUNY Academic Commons - CUNY Graduate Center - Project Tracking System

Actions

Copy link

Bug #15219

closed

Alignment with Rowling Theme

Added by Laurie Hurson almost 3 years ago. Updated over 2 years ago.

Status:

Resolved

Priority name:

Normal

Assignee:

Raymond Hoh

Category name:

Layout

Target version:

1.19.3

Start date:

2022-01-25

Due date:

% Done:

Estimated time:

Deployment actions:

Description

Hi All,

I noticed the alignment of the posts and images in the rowling theme seems to off. There used to be more padding/spacing between the post images.

Live Example: https://eng298.commons.gc.cuny.edu/

Screenshot of old spacing attached

Files

Screen Shot 2022-01-25 at 6.19.50 PM.png (1.83 MB) Screen Shot 2022-01-25 at 6.19.50 PM.png

Laurie Hurson, 2022-01-25 06:20 PM

Actions

Copy link

Updated by Laurie Hurson almost 3 years ago

File Screen Shot 2022-01-25 at 6.19.50 PM.png Screen Shot 2022-01-25 at 6.19.50 PM.png added

Actions

Copy link

Updated by Boone Gorges almost 3 years ago

Assignee set to Raymond Hoh

It looks like the flex layout is being broken by the appearance of the cookies-for-logins css.php, just at the beginning of the #posts element.

Ray, in #11453 we introduced the trick of injecting this item further up the page, at loop_start. How do you think we can mitigate the problem? Should/can we move it back to the footer, where it used to be? Is there a way to move it elsewhere in the DOM that won't cause similar snags for other themes? What if we moved to the 'stylesheet' method for cookies-for-logins? Or is there something we can do with CSS to leave the element where it is, but not wreck the flex layout in this case?

Actions

Copy link

Updated by Raymond Hoh almost 3 years ago

Category name set to Layout
Status changed from New to Staged for Production Release
Target version set to 1.19.3

What if we moved to the 'stylesheet' method for cookies-for-logins?

That would work but stylesheets are render-blocking requests, so this might slow down browser parsing a little bit.

Or is there something we can do with CSS to leave the element where it is, but not wreck the flex layout in this case?

I tried a few things in CSS, but that flexbox is pretty stubborn!

Is there a way to move it elsewhere in the DOM that won't cause similar snags for other themes?

It's not really possible to move the cookies-for-comments image anywhere else in the <body>. The 'wp_body_open' hook could have been a possibility, but not all themes use that hook, so...