Project

General

Profile

Bug #15219

Alignment with Rowling Theme

Added by Laurie Hurson 4 months ago. Updated 3 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Layout
Target version:
Start date:
2022-01-25
Due date:
% Done:

0%

Estimated time:

Description

Hi All,

I noticed the alignment of the posts and images in the rowling theme seems to off. There used to be more padding/spacing between the post images.

Live Example: https://eng298.commons.gc.cuny.edu/

Screenshot of old spacing attached

History

#2 Updated by Boone Gorges 4 months ago

  • Assignee set to Raymond Hoh

It looks like the flex layout is being broken by the appearance of the cookies-for-logins css.php, just at the beginning of the #posts element.

Ray, in #11453 we introduced the trick of injecting this item further up the page, at loop_start. How do you think we can mitigate the problem? Should/can we move it back to the footer, where it used to be? Is there a way to move it elsewhere in the DOM that won't cause similar snags for other themes? What if we moved to the 'stylesheet' method for cookies-for-logins? Or is there something we can do with CSS to leave the element where it is, but not wreck the flex layout in this case?

#3 Updated by Raymond Hoh 4 months ago

  • Category name set to Layout
  • Status changed from New to Staged for Production Release
  • Target version set to 1.19.3

What if we moved to the 'stylesheet' method for cookies-for-logins?

That would work but stylesheets are render-blocking requests, so this might slow down browser parsing a little bit.

Or is there something we can do with CSS to leave the element where it is, but not wreck the flex layout in this case?

I tried a few things in CSS, but that flexbox is pretty stubborn!

Is there a way to move it elsewhere in the DOM that won't cause similar snags for other themes?

It's not really possible to move the cookies-for-comments image anywhere else in the <body>. The 'wp_body_open' hook could have been a possibility, but not all themes use that hook, so...

Should/can we move it back to the footer, where it used to be?

Let's do this instead. Just committed this in https://github.com/cuny-academic-commons/cac/commit/40a31d134875ef594abf7fde5875d4799ae51431. I haven't pushed this to production yet though.

#4 Updated by Boone Gorges 4 months ago

Sounds good. Thanks, Ray!

#5 Updated by Laurie Hurson 4 months ago

Thanks all!

#6 Updated by Boone Gorges 3 months ago

  • Status changed from Staged for Production Release to Resolved

Also available in: Atom PDF