Project

General

Profile

Actions
Copy link

Bug #18016

open

ml-slider get_plugins() call causes performance issues

Added by Boone Gorges about 2 years ago. Updated 12 days ago.

Status:
Hold
Priority name:
Normal
Assignee:
Boone Gorges
Category name:
Internal Tools and Workflow
Target version:
2.5.7
Start date:
2023-04-12
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

See discussion at https://redmine.gc.cuny.edu/issues/15767#note-2 and follow-up. The ml-slider folks have promised to fix the issue, but have not done so. https://wordpress.org/support/topic/call-to-get_plugins-causing-performance-problems/

Until they do, we will need to patch ml-slider each time it's updated. This happens next in the 2.1.5 release.

We should also have some sort of system for notifying the release manager (ie me) whenever this patch needs to be applied. Looking at GitHub Actions results is already part of my workflow, which helps me catch invalid syntax and other items. But this one is kinda hard to catch with static analysis tools. Instead, I'm thinking I'll add something to the wp-cli-cac script that I use for bulk plugin updates, something that throws a huge notice about plugins that need manual attention after they've received an update.

Related issues

Related to CUNY Academic Commons - Support #15767: Site loading slowlyResolvedBoone Gorges2022-03-30

Actions
Related to CUNY Academic Commons - Bug #18098: Disable NextGen Gallery's cache trackerResolvedRaymond Hoh2023-04-21

Actions
Related to CUNY Academic Commons - Bug #18417: Call to undefined function is_plugin_active()ResolvedBoone Gorges2023-06-27

Actions
Actions
Copy link
 #1

Updated by Boone Gorges about 2 years ago

Actions
Copy link
 #2

Updated by Boone Gorges almost 2 years ago

  • Target version changed from 2.1.5 to 2.1.6

I've manually applied the patch for this release.

I've got a tentative fix in my wp-cli-cac tool that will generate a warning when ml-slider is updated: https://github.com/cuny-academic-commons/wp-cli-cac/commit/5b61e22af11ff532aff22b0d50b1b52427d62642 I'll test this with my next set of updates.

Actions
Copy link
 #3

Updated by Boone Gorges almost 2 years ago

  • Status changed from New to Hold
  • Target version changed from 2.1.6 to 2.1.7

Waiting for another release before closing this ticket. See https://redmine.gc.cuny.edu/issues/18098#note-7 for more information.

Actions
Copy link
 #4

Updated by Boone Gorges almost 2 years ago

  • Related to Bug #18098: Disable NextGen Gallery's cache tracker added
Actions
Copy link
 #5

Updated by Boone Gorges almost 2 years ago

  • Target version changed from 2.1.7 to 2.1.8

There was a slight error in my script that warns about updates to ml-slider. I caught it and was able to manually patch. I'll push this to the next release so that I can monitor again.

Actions
Copy link
 #6

Updated by Boone Gorges almost 2 years ago

  • Target version changed from 2.1.8 to 2.1.9
Actions
Copy link
 #7

Updated by Boone Gorges almost 2 years ago

  • Target version changed from 2.1.9 to 2.1.10
Actions
Copy link
 #8

Updated by Boone Gorges almost 2 years ago

  • Related to Bug #18417: Call to undefined function is_plugin_active() added
Actions
Copy link
 #9

Updated by Boone Gorges almost 2 years ago

  • Target version changed from 2.1.10 to 2.1.11
Actions
Copy link
 #10

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.1.11 to 2.1.12
Actions
Copy link
 #11

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.1.12 to 2.1.13
Actions
Copy link
 #12

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.1.13 to 2.1.14
Actions
Copy link
 #13

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.1.14 to 2.1.15
Actions
Copy link
 #14

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.1.15 to 2.1.16

ml-slider was updated in the most recent round of updates and the fixes still have not been implemented upstream. I'm afraid I forgot to check whether my CLI tool warning showed properly during the update process, so I'm going to continue to push this ticket. I've applied the necessary hotfixes in https://github.com/cuny-academic-commons/cac/commit/b69c5196dc51f4cc630927e37fc69b205d22966d for the time being.

Actions
Copy link
 #15

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.1.16 to 2.2.1
Actions
Copy link
 #16

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.2.1 to 2.2.2
Actions
Copy link
 #17

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.2.2 to 2.2.3
Actions
Copy link
 #18

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.2.3 to 2.2.4
Actions
Copy link
 #19

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.2.4 to 2.2.5
Actions
Copy link
 #20

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.2.5 to 2.2.6
Actions
Copy link
 #21

Updated by Boone Gorges over 1 year ago

  • Target version changed from 2.2.6 to 2.3.1
Actions
Copy link
 #22

Updated by Boone Gorges about 1 year ago

  • Target version changed from 2.3.1 to 2.3.2
Actions
Copy link
 #23

Updated by Boone Gorges about 1 year ago

  • Target version changed from 2.3.2 to 2.3.3
Actions
Copy link
 #24

Updated by Boone Gorges about 1 year ago

  • Target version changed from 2.3.3 to 2.3.4
Actions
Copy link
 #25

Updated by Boone Gorges about 1 year ago

  • Target version changed from 2.3.4 to 2.3.5
Actions
Copy link
 #26

Updated by Boone Gorges about 1 year ago

  • Target version changed from 2.3.5 to 2.3.6

The authors still have not fixed the issues. Hotfix applied in https://github.com/cuny-academic-commons/cac/commit/ed8ab02bbcdf3a3357ba939471f9ca7fd13bfe32

Actions
Copy link
 #28

Updated by Boone Gorges 11 months ago

  • Target version changed from 2.3.7 to 2.3.8
Actions
Copy link
 #29

Updated by Boone Gorges 11 months ago

  • Target version changed from 2.3.8 to 589
Actions
Copy link
 #30

Updated by Boone Gorges 10 months ago

  • Target version changed from 589 to 2.4.1
Actions
Copy link
 #31

Updated by Boone Gorges 10 months ago

  • Status changed from Hold to Staged for Production Release
Actions
Copy link
 #32

Updated by Boone Gorges 10 months ago

  • Status changed from Staged for Production Release to Resolved
Actions
Copy link
 #33

Updated by Boone Gorges 10 months ago

  • Status changed from Resolved to Hold
  • Target version changed from 2.4.1 to 2.4.2
Actions
Copy link
 #34

Updated by Boone Gorges 9 months ago

  • Target version changed from 2.4.2 to 2.4.3
Actions
Copy link
 #35

Updated by Boone Gorges 9 months ago

  • Target version changed from 2.4.3 to 2.4.4
Actions
Copy link
 #36

Updated by Boone Gorges 8 months ago

  • Target version changed from 2.4.4 to 2.4.5
Actions
Copy link
 #37

Updated by Boone Gorges 8 months ago

  • Target version changed from 2.4.5 to 2.4.6
Actions
Copy link
 #38

Updated by Boone Gorges 7 months ago

  • Target version changed from 2.4.6 to 2.4.7
Actions
Copy link
 #39

Updated by Boone Gorges 7 months ago

  • Target version changed from 2.4.7 to 2.4.8
Actions
Copy link
 #40

Updated by Boone Gorges 6 months ago

  • Target version changed from 2.4.8 to 2.4.9
Actions
Copy link
 #41

Updated by Boone Gorges 6 months ago

  • Target version changed from 2.4.9 to 2.4.10
Actions
Copy link
 #42

Updated by Boone Gorges 5 months ago

  • Target version changed from 2.4.10 to 601
Actions
Copy link
 #43

Updated by Boone Gorges 4 months ago

  • Target version changed from 601 to 2.5.1
Actions
Copy link
 #44

Updated by Boone Gorges 3 months ago

  • Target version changed from 2.5.1 to 2.5.2
Actions
Copy link
 #45

Updated by Boone Gorges 2 months ago

  • Target version changed from 2.5.2 to 2.5.3
Actions
Copy link
 #46

Updated by Boone Gorges about 2 months ago

  • Target version changed from 2.5.3 to 2.5.4

Hotfixes applied in https://github.com/cuny-academic-commons/cac/commit/892cea0ef284be74ead39779d1b2f0364af6f720

Unfortunately, I don't see a path forward with this plugin except to reapply these fixes on major updates. The plugin author doesn't seem to care about the issue.

Actions
Copy link
 #47

Updated by Boone Gorges about 1 month ago

  • Target version changed from 2.5.4 to 2.5.5
Actions
Copy link
 #48

Updated by Boone Gorges 26 days ago

  • Target version changed from 2.5.5 to 2.5.6
Actions
Copy link
 #49

Updated by Boone Gorges 12 days ago

  • Target version changed from 2.5.6 to 2.5.7
Actions
Copy link

Also available in: Atom PDF