Project

General

Profile

Actions

Bug #18016

open

ml-slider get_plugins() call causes performance issues

Added by Boone Gorges 6 months ago. Updated 13 days ago.

Status:
Hold
Priority name:
Normal
Assignee:
Category name:
Internal Tools and Workflow
Target version:
Start date:
2023-04-12
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

See discussion at https://redmine.gc.cuny.edu/issues/15767#note-2 and follow-up. The ml-slider folks have promised to fix the issue, but have not done so. https://wordpress.org/support/topic/call-to-get_plugins-causing-performance-problems/

Until they do, we will need to patch ml-slider each time it's updated. This happens next in the 2.1.5 release.

We should also have some sort of system for notifying the release manager (ie me) whenever this patch needs to be applied. Looking at GitHub Actions results is already part of my workflow, which helps me catch invalid syntax and other items. But this one is kinda hard to catch with static analysis tools. Instead, I'm thinking I'll add something to the wp-cli-cac script that I use for bulk plugin updates, something that throws a huge notice about plugins that need manual attention after they've received an update.


Related issues

Related to CUNY Academic Commons - Support #15767: Site loading slowlyResolvedBoone Gorges2022-03-30

Actions
Related to CUNY Academic Commons - Bug #18098: Disable NextGen Gallery's cache trackerResolvedRaymond Hoh2023-04-21

Actions
Related to CUNY Academic Commons - Bug #18417: Call to undefined function is_plugin_active()ResolvedBoone Gorges2023-06-27

Actions
Actions #1

Updated by Boone Gorges 6 months ago

Actions #2

Updated by Boone Gorges 5 months ago

  • Target version changed from 2.1.5 to 2.1.6

I've manually applied the patch for this release.

I've got a tentative fix in my wp-cli-cac tool that will generate a warning when ml-slider is updated: https://github.com/cuny-academic-commons/wp-cli-cac/commit/5b61e22af11ff532aff22b0d50b1b52427d62642 I'll test this with my next set of updates.

Actions #3

Updated by Boone Gorges 5 months ago

  • Status changed from New to Hold
  • Target version changed from 2.1.6 to 2.1.7

Waiting for another release before closing this ticket. See https://redmine.gc.cuny.edu/issues/18098#note-7 for more information.

Actions #4

Updated by Boone Gorges 5 months ago

  • Related to Bug #18098: Disable NextGen Gallery's cache tracker added
Actions #5

Updated by Boone Gorges 4 months ago

  • Target version changed from 2.1.7 to 2.1.8

There was a slight error in my script that warns about updates to ml-slider. I caught it and was able to manually patch. I'll push this to the next release so that I can monitor again.

Actions #6

Updated by Boone Gorges 3 months ago

  • Target version changed from 2.1.8 to 2.1.9
Actions #7

Updated by Boone Gorges 3 months ago

  • Target version changed from 2.1.9 to 2.1.10
Actions #8

Updated by Boone Gorges 3 months ago

  • Related to Bug #18417: Call to undefined function is_plugin_active() added
Actions #9

Updated by Boone Gorges 3 months ago

  • Target version changed from 2.1.10 to 2.1.11
Actions #10

Updated by Boone Gorges 2 months ago

  • Target version changed from 2.1.11 to 2.1.12
Actions #11

Updated by Boone Gorges about 2 months ago

  • Target version changed from 2.1.12 to 2.1.13
Actions #12

Updated by Boone Gorges about 1 month ago

  • Target version changed from 2.1.13 to 2.1.14
Actions #13

Updated by Boone Gorges 13 days ago

  • Target version changed from 2.1.14 to 2.1.15
Actions

Also available in: Atom PDF