CUNY Academic Commons

Boone, I've added a new branch for the cac-onboarding plugin -- bp-notifications -- that adds three new BP notifications:
1. When an invite is sent to an existing user, a BP notification is also created for the existing user
2. When an invite is accepted, a BP notification is sent to the inviter to let them know about the update
3. When an invite is rejected, a BP notification is sent to the inviter to let them know about the update

When an invite is accepted or rejected, the first notification is also deleted.

Some other commits were added to re-use the existing invite action logic and so invite action redirection can be done when accepting or declining an invite from the new "Notifications > All" and "Notifications > Action Center" pages.

This is available for testing on cdev.

https://github.com/cuny-academic-commons/cac-onboarding/compare/master...bp-notifications#diff-b4c7194fc66905032f77edc20b8785bf7d4e43869815c8a8b20e69c8dc10dd7fR116

Wow.

This all looks good to me. Thanks, Ray!

Boone, I'm working through a WP-CLI script to backfill notifications for invites created by the cac-onboarding plugin.

Here's what I have so far:

<?php

global $wpdb;

$invites = $wpdb->get_results( "select id,invitee_id,inviter_id,date_created from wp_1_cac_invites where status = 'pending' and invitee_id != 0" );

$progress = \WP_CLI\Utils\make_progress_bar( 'Generating notifications', count( $invites ) );

foreach ( $invites as $invite ) {
    $progress->tick();

    bp_notifications_add_notification( array(
        'user_id'           => $invite->invitee_id,
        'item_id'           => $invite->id,
        'secondary_item_id' => $invite->inviter_id,
        'date_notified'     => $invite->date_created,
        'component_name'    => 'caco',
        'component_action'  => 'new_invitation',
    ) );
}

$progress->finish();

The script works but when I do a query to see how many pending invites there are on the production database, that number is quite large:

mysql> select count(*) from wp_1_cac_invites where status = 'pending' and invitee_id != 0;
+----------+
| count(*) |
+----------+
|     4280 |
+----------+
1 row in set (0.08 sec)                                                          

I'm wondering why we have a ton of pending invites when inviting an existing user.

Do you think we should limit creating notifications if the date_created for the invite is older than January 1, 2023 or a more, recent date? If using January 1st as the cut-off date, the notifications to create would be 656 instead.

I'm wondering why we have a ton of pending invites when inviting an existing user.

Yeah, that's strange. There could be a bug in cac-onboarding preventing them from being marked as accepted, but it's obviously not totally broken:

> select count(*) from wp_1_cac_invites where status != 'pending' and invitee_id != 0;
+----------+
| count(*) |
+----------+
|    26279 |
+----------+
1 row in set (0.04 sec)

Anyway, I agree that we don't need to backfill for all or even most of these. Jan 1 2023 seems OK to me if it does to you.