CUNY Academic Commons

Boone, it looks like the edit_item() method needs to take into account changes to the library item's title and description. If there are no changes to the title or description or if the "Silent Item" checkbox is checked, then we should run the silence_update() routine in the edit_item() method to prevent activity items from recording and subsequently, email notifications from sending. Does that sound about right?

Boone, it looks like the edit_item() method needs to take into account changes to the library item's title and description. If there are no changes to the title or description or if the "Silent Item" checkbox is checked, then we should run the silence_update() routine in the edit_item() method to prevent activity items from recording and subsequently, email notifications from sending. Does that sound about right?

No, I think there's a bug in cac-group-library that's causing the silentUpdate param to be ignored when editing (as opposed to creating). The Silent Edit checkbox was, in fact, checked, it was just being ignored. This is fixed in https://github.com/cuny-academic-commons/cac-group-library/commit/bc03be93c8d6574e0287fa2c9cb73442286cc5f0 and will be part of the next release.

the notification that did come had the subject line start with "New file -- [folder name]" -- which seemed a bit odd, as I hadn't added a new file, but merely edited the folder in which an existing file appeared

I see this too. The 'New File' text comes from our customizations at https://github.com/cuny-academic-commons/cac/blob/61ce15a3bafa779063c53e5313f62ba9da54bdf0/wp-content/plugins/cac-bp-custom-includes/email-notifications.php#L297. But this happens because the buddypress-group-documents plugin is generating an activity item with the action 'added_group_document', even in the case of edits. I don't know why this is. IMO it's not worth a lot of debugging at this time, especially since these notifications are silenced by default.