Project

General

Profile

Actions

Bug #19202

closed

bp-nelo doesn't have 404 template

Added by Boone Gorges 6 months ago. Updated 5 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
-
Target version:
Start date:
2023-11-03
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

This is presumably because we no longer inherit bp-default templates.

As a result, 404 requests - including non-authenticated requests to hidden groups - show a white screen.

Discovered in connection with #19201.

Actions #1

Updated by Raymond Hoh 6 months ago

Groan.

I'm about to put up a template with the following content:

Heading: Page Not Found
Content: The page you were looking for could not be found. It might have been removed, renamed, or did not exist in the first place.

I took this copy from the Twenty Twenty theme. However, let me know if we want to change the copy to something else.

The good thing is this gives us a chance to revamp the 404 page. Should we add a blurb like "If you are attempting to view a private page, please login below." and show a login form directly underneath?

Actions #2

Updated by Raymond Hoh 6 months ago

  • Status changed from New to Staged for Production Release

I've committed the barebones 404 template for now: https://github.com/cuny-academic-commons/cac/commit/03ab614449ae7f81247109bf23c9658f635ff28a and have pushed the commit to production.

I haven't added my suggestion about the login form yet. We can add it if everyone thinks it is a good idea.

Actions #3

Updated by Matt Gold 5 months ago

seems to make sense to me. thanks for your work on this, Ray.

Actions #4

Updated by Boone Gorges 5 months ago

Thanks, Ray! The login form suggestion sounds pretty good to me, with the caveat that it should appear all the time. That is, we should not show the login screen only when the user has attempted an off-limits resource, because hidden groups are not meant to be discoverable in this way.

Actions #5

Updated by Raymond Hoh 5 months ago

I've added the login form to the 404 template if a user is not logged in: https://github.com/cuny-academic-commons/cac/commit/f2c86139d4c57f60e87c83b05f7c5c1af3b8c3c9 . This will be part of the next maintenance release on the 14th.

Actions #6

Updated by Boone Gorges 5 months ago

  • Status changed from Staged for Production Release to Resolved
Actions

Also available in: Atom PDF