Bug #19810
closedGroup + Site Creation flow back button creates error
0%
Description
There is a "back to previous step" button when cloning a group and site that creates an error when you go back to the group (which was already created)
This is on cdev (see attached screen recording)
Files
Updated by Raymond Hoh 9 months ago
- Subject changed from Site Creation flow back button creates error to Group + Site Creation flow back button creates error
- Assignee changed from Raymond Hoh to Boone Gorges
Boone, can you take a look at this since you are more familiar with the cloning process than I am?
A brief summary is when the previous step button is clicked, it uses an onclick handler that redirects back to the first step URL -- https://commons.gc.cuny.edu/groups/create/step/group-details/. However, when creating a group + site, we append the ?do-groupblog=1 query to the URL: https://github.com/cuny-academic-commons/cac/blob/03c5f0247f055047ec5429d32bb9cb3f0894d84a/wp-content/themes/bp-nelo/page-create.php#L82 . This isn't being recognized in the onclick handler.
- If the "Clone an Existing Group" option was selected in the first step, this option is forgotten when the previous step button is clicked and is reset to "Create a New Group"
- Campus and Primary Purpose fields are reset and do not use the previously-saved values
Updated by Boone Gorges 9 months ago
- Category name set to Groups (misc)
- Target version set to 2.4.0
Thanks for the detailed report.
In https://github.com/cuny-academic-commons/cac/commit/2bcf6b6f9532d529d63ccc499a8577b915ebc688 I put a few fixes in place. For the time being, I've staged this only in the 2.4.x branch, as it touches a number of different aspects of the group creation process and I'm wary of shipping without some testing. Ray and Sara, if you are able to have a look, I can put it back into a 2.3.x release. (cdev is now running the 2.4.x branch.)