CUNY Academic Commons

OK, I'll take a crack at it.

Some really great points and insights, Chris. Of the three possibilities you put together, I think that v3 is the cleanest, though I wonder whether the Commons logo should appear right below the HR line. If we need to mirror that on the right by having the CUNY logo above the "powered by" language, that would be fine.

Not sure about the 2010 Commons stuff. I think we didn't want to have a copyright symbol there because we were going with CC licenses. Maybe we should delete that line.

Just a note that CC licenses and copyright are not mutually exclusive; in fact, CC only makes sense in the presence of copyright.

Matt, moving the images sounds fine. I'm doing daddy daycare and I'm under the weather so I may not be able to make the changes and upload the HTML/CSS file until nap time.

Boone, thanks for the note, which is as I understand it as well. Perhaps it makes sense to have a © 2012 CUNY Academic Commons, on the main site and then not have that on individual blogs.

Thanks, Chris. I may be missing something, but I don't see the screenshot. Can you repost if it's not already here? Many thanks.

I did forget it. I'm having a charging problem with my laptop, on the iPad now. If I can fix the problem soon I'll update it. If. It it is basically v3 with the logos at the top of each side.

Looks really great, Chris -- I think the repositioning works well. What do you think of reducing the vertical line spacing between "Built with/Protected by/Powered by"? Those lines extend the overall vertical height of the footer, leaving blank space over on the left, and I wonder how it would look with things a bit more compact on the bottom. What do you think?

Thanks so much, Chris -- I think these do help. My preference is for footerV6_2.png since it really makes a difference on the size of the footer and looks good overall. I like the drama of the line breaks in v5, but I'm not sure they're worth the extra space they take up.

What do you think?

I suppose that another possibility is to keep the line breaks but to move the "this blog is part of the CUNY Academic Commons" and "unless otherwise stated" lines under the CAC logo/nav links, thus bringing everything under the white horizontal rule. Having said that, since the referent of "this blog" is the material directly above that line, it's probably best to keep it where it is.

I'm not too concerned about the space in the footer since it's the last thing on the page and it's just three lines. I'll be fine with either version, so go for the one that you feel most inclined towards. I do like keeping the sentences separate since I think they are more likely to get read that way and for your reasoning too.

Okay -- thanks, Chris. Let's go with V6_2.png, then. I think it's a big improvement and I appreciate your work on this.

Thanks so much, Chris.

Updating this issue to make sure that our footer lists 24 campuses, not 23, per this ticket: http://redmine.gc.cuny.edu/issues/2115

Hi Dom:

Can you take a look at this issue and verify status? We'd like to include this in the new major release with minor text changes (eg 23-24 campuses) from Matt.

No prob, I'll take a look at this one again today. I reviewed it a few days ago, I don't think it'll be too difficult to get this into the next major release. I'll update in a day or two with either a resolution or status.

I agree, the futzing around inside the different parts of our footer is what I haven't been able to get too. I'll update you later today to let you know what I was able to do today or if I wasn't able to get to it. That way you'll know if you need to look into it tomorrow.

Boone,

I've gone back and re-read this thread to make sure I didn't miss anything. From what I can gather, Matt and Chris decided that Chris' "footerV6_2.png" version was they way they wanted to go. You can see that pic at this link:

http://redmine.gc.cuny.edu/attachments/download/746/footerV6_2.png

I agree, this footer looks really nice. I'm assuming that a resolution to this issue would require me to make small changes to both the bp-nelo theme's footer.php as well as the code in /plugins/cac-sitewide-footer.php to reflect the requested changes. I'm going to create a topic-branch off of master so you can review the changes before merging them into the 1.5 release.

But, before I start making these changes I just wanted to make sure I understood correctly; this issue has been running for quite a while and I don't want to go in the wrong direction. Does the info above sound correct to you? Would you rather I branch off of another line than master? This issue is requesting changes to both The Commons footer AND the sitewide footer, correct?

Let me know if I've missed anything or misunderstood any part of the request above. Once I've heard from you I'll make the changes using the files Chris has attached above and push the topic branch up to our repo tonight so you can review and merge it tomorrow.

Hi Dom,

Yes, that's the correct design (footerV6_2.png). Please also note that Chris has shared his HTML and CSS http://redmine.gc.cuny.edu/issues/2000#note-20, which will probably do much of the work for you.

And yes, this is a change that needs to be made both in bp-nelo and in plugins/cac-sitewide-footer.php

Please do branch off of master; this'll become 1.5.

Thanks!

Awesome, I did see (and have already downloaded) Chris' HTML and CSS.

I'll make the changes and push up the topic branch tonight, then notify you here so you can review.

Boone,

I've pushed up the topic branch with the changes from Chris' HTML and CSS files. It's looking good. The white CUNY image is broken in local testing because it is trying to load it from the same location on the live site as the Commons logo. So that will stay broken until the next production deploy, but should work no problem after that.

Commit: https://github.com/castiron/cac/commit/300a22aa558ee9778466da2a7d918d4c005a10dc

Turns out the sitewide-footer plugin is loading it's CSS on all pages, so I've left the bp-nelo footer wrapped in a div with a class of sitewide-footer. This simplified the styling and ensures that the Commons footer and all other site wide footers look exactly the same. I think what we should do is either move this ticket to a 1.5.1 target to discuss further improvements and simplifications to the footer code or start a new issue. There are probably a few more things we could do to streamline the footer from bp-nelo to the sitewide plugin. I'm thinking a bunch of footer css in custom.css could probably be removed or merged with the CSS Chris included for the sitewide footer.

Let me know what you think.

You're welcome. All of the improvements you made were the topics I thought we could move into the 1.5.1 target if we wanted to pursue them, but since you knocked them out, we don't need to.

I'd also like to thank Chris for his hard work as well. His HTML and CSS files made the job much simpler than a styling and layout redesign from scratch would have been.