Project

General

Profile

Actions

Bug #21141

closed

Group detail update notification

Added by Matt Gold about 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Groups (misc)
Target version:
Start date:
2024-10-02
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Hi Ray -- I received the attached group details update, which seemed like it was missing some information about what was actually updated. I'm wondering whether this was user error or maybe nothing much was changed. Can you please investigate/test and see whether group detail change notifications are working as they should?


Files

Actions #1

Updated by Raymond Hoh about 2 months ago

  • Target version set to 2.4.8

This email is fired when a setting is changed under a group's "Manage > Details" page and the "Notify group members of these changes via email" option is checked.

However only changes to the group's name or description would populate the email. Our custom group detail fields such as Quick Link, Campus, Primary Purpose and Social Media fields are not reflected in the email at the moment. We would have to add some code so these changes will be part of the email. Will look to add this before the next maintenance release.

Actions #2

Updated by Raymond Hoh about 2 months ago

  • Status changed from New to Staged for Production Release

If the Quick Link, Campus, Primary Purpose or Social Media accounts are changed, these are now reflected in the group details email in https://github.com/cuny-academic-commons/cac/commit/42cda8c350069bd4247c680cb64958a0beceecfc. Also if the group name or description is not changed, the group details email will not be sent.

Boone, I'm short-circuiting the group details email and delaying it until after the Quick Link meta is saved. This is where I do all the logic to check if the group details have changed or not. For the Social Media block, I'm only adding if there are new social media changes and not removals to the email to make the email content less busy. I also had to copy some URL logic from the cac_group_social_media_links() function to parse the social media URLs. This could be improved, but that's good enough for now.

Actions #3

Updated by Boone Gorges about 2 months ago

  • Status changed from Staged for Production Release to Resolved
Actions

Also available in: Atom PDF