Project

General

Profile

Actions

Bug #21690

closed

No silent upload for external link item

Added by Colin McDonald 12 months ago. Updated about 1 month ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Group Library
Target version:
Start date:
2024-12-30
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

I noticed working on the #21427 migration testing steps that when adding an external link item in a Group library, there is no option to make it a "silent upload," as you can do for editable docs and files. Should that option should exist for all three? Obviously very low priority right now, but I wanted to make a note for when other things slow down.


Related issues

Related to CUNY Academic Commons - Bug #23547: Email notifications of link uploads not sentDuplicateRaymond Hoh2025-09-25

Actions
Actions #1

Updated by Boone Gorges 12 months ago

  • Target version set to 2.6.0

We'll see if we can have a look at this for the spring release.

Actions #2

Updated by Matt Gold 11 months ago

great catch, Colin!

Actions #3

Updated by Colin McDonald 3 months ago

Just bumping this ticket to see if it is manageable for our release this fall. If so, who should run point on it from dev?

Actions #4

Updated by Boone Gorges 3 months ago

I will handle implementation.

It appears to me that we don't actually send emails at all for the creation of new external links. So what we need is to implement this feature, and then add a 'Silent' toggle to turn it off. Colin, does that seem right to you?

Actions #5

Updated by Colin McDonald 3 months ago

Adding Sara in case she has any thoughts. I hate to make it more complicated if emails aren't being sent at all right now, but it does make sense to me that each type of addition to the Library works in the same way (notifies the group upon upload, unless it's marked Silent).

Actions #6

Updated by Raymond Hoh 3 months ago

  • Related to Bug #23547: Email notifications of link uploads not sent added
Actions #7

Updated by Matt Gold 3 months ago

Just noting this as a bit of a priority -- as a teacher using the Commons, I expected that students were notified when I uploaded a reading. not having that notification go out could affect classes, so I'd bump this up ahead of some of our other word. Not urgent, certainly, but also not something to put off if we can help it

Actions #8

Updated by Colin McDonald 3 months ago

Just noting that we do have this pegged for our fall release, which we've been planning to have out in November. We could discuss breaking this out to ship earlier.

Actions #9

Updated by Boone Gorges 2 months ago

  • Status changed from New to Testing Required

I've implemented activity items for new External Link items. These activity items are responsible for triggering BPGES email notifications, parallel to how Docs and Files work. I've also added a Silent checkbox, which works the same as the other library item types.

https://github.com/cuny-academic-commons/cac-group-library/commit/f65f4f792295b5ffb82aaa68e80f593e75f0c262
https://github.com/cuny-academic-commons/cac/commit/e95547d1bd0ec7988e35e538dc79533a7701bcfe
https://github.com/cuny-academic-commons/cac/commit/c2b86a0c75c1764baff63d290c9d747090b43c4c

Actions #10

Updated by Raymond Hoh 2 months ago

Thanks Boone!

In https://github.com/cuny-academic-commons/cac/commit/8e0bbee95924545a162705e3c77dadbd244b1cdf, I've tweaked the external link email so that:
- The subject line is New Link - [LINK TITLE]
- The full URL for the external link is displayed for those using plain-text emails.
- The main CTA button is renamed to "View Group Links" and links directly to the Group Library, filtered by External Link.

Also in https://github.com/cuny-academic-commons/cac-group-library/commit/9de5ab408271074dbba3748f9da7d961da9b1c37, when the external link is deleted, the corresponding activity item is also removed.

Actions #11

Updated by Boone Gorges 2 months ago

Thanks, Ray! I took care of the parts of the email that made sense to me, but I missed a few :) Thanks for cleaning up.

Actions #12

Updated by Colin McDonald about 2 months ago

I tested all aspects of this, and I think it's ready to go. Thanks, Boone and Ray!

Actions #13

Updated by Boone Gorges about 1 month ago

  • Status changed from Testing Required to Staged for Production Release
Actions #14

Updated by Boone Gorges about 1 month ago

  • Status changed from Staged for Production Release to Resolved
Actions

Also available in: Atom PDF