Bug #23376
openDesign/UX #22840: Email Documentation & Design Updates
Add support to disable some email notification options
0%
Description
During an audit of our emails in #22840, I've discovered that on the "Account Settings > Notifications" page, there are a few options we display, but currently do not respect:
- A member invites you to join a group
- A member uploads a document to a group you belong to - This one is from the BP Group Documents plugin, but we add our own email through the Group Email Subscription plugin.
- A member uploads a document to a group for which you are an moderator/admin
If you disable these options, you will still receive these email notifications.
The first option is a built-in BuddyPress option, but we have our own onboarding invites system that supercedes this. We currently do not do checks against this option when sending our custom invitation email. The latter two options are from the BP Group Documents plugin, but we disable their email and add a custom one through the Group Email Subscription plugin. We currently do not do checks against these options when a group member is subscribed to the 'All Mail' option.
What do we want to do here? Do we want to remove these options entirely from the "Account Settings > Notifications" page? Or do we want to add support to disable these emails?
My suggestion would be to remove these options from the "Account Settings > Notifications" page as invites are a vital part of the Commons and group document emails might be a little too targeted to have for a global email option. Thoughts?
Updated by Boone Gorges about 1 month ago
I agree that we should remove these settings from Settings > Notifications. Invite-to-group emails shouldn't really be disable-able, I think. "Member uploads a document to a group..." should be handled on a per-group basis, using the BPGES settings.
Updated by Colin McDonald about 1 month ago
Sounds good to me, too. Thanks for the catch, Ray!
Updated by Raymond Hoh about 1 month ago
- Status changed from New to Staged for Production Release
I've removed the email options listed above in https://github.com/cuny-academic-commons/cac/commit/001c0e074e35f30b8c6e3f5ca639cd945625e8c2.