Bug #23731
openStray search icon on logged-out homepage toolbar
0%
Description
I noticed the icon in the attached screenshot on the logged-out homepage where I don't recall seeing one in the past. When you click on it, it brings up a kind of clunky mini search bar, and then the results page is also pretty odd. Perhaps this just needs to be hidden?
Files
Updated by Raymond Hoh 5 days ago
Hi Colin, do we want to remove this search icon sitewide or just on the main site?
Updated by Colin McDonald 5 days ago
Hi Ray, is it just me or did this icon appear recently? I feel like we would have noticed it before, especially because it's kind of off-kilter with the rest of the admin bar layout and nearby links.
If it is a recent appearance, I doubt anyone's going to miss it, and it doesn't seem to do much that is useful from what I can tell. I haven't tested it on a lot of subdomains or anything though -- is that what you mean by sitewide?
Updated by Raymond Hoh 5 days ago
- Category name set to Toolbar
- Status changed from New to Staged for Production Release
- Target version set to 2.5.17
I haven't tested it on a lot of subdomains or anything though
In WordPress, the search icon in the admin bar appears to be quite old. It is meant to be used as a shortcut to search for a site's content, usually blog posts.
is that what you mean by sitewide?
By sitewide, I mean that the icon is usually displayed in the admin bar of every site. For the Commons, we removed the search icon in the admin bar for logged-in users only about a year ago in https://github.com/cuny-academic-commons/cac/commit/0910b319ca6c27d66fc894d2863b3fc41674ec7b as part of #21411, but we never removed it for logged-out users. I've just removed the search icon for logged-out users to be consistent in https://github.com/cuny-academic-commons/cac/commit/3d0cf49e10c8e9cff4bc936d63ccdc6b36d54f3d.
This will be part of the next maintenance release on the 28th, unless we want to deploy it earlier than then.
Updated by Colin McDonald 1 day ago
Hi Ray, after our discussion on the call today I played around some more with this search icon on other sites besides the main site, and it seems to work fine there and offer some utility, especially if the site you're on doesn't have a search bar in the top nav for whatever reason. Let's just remove it for the main Commons site, where it doesn't seem to work and clutters up the toolbar. Thanks!
Updated by Raymond Hoh 30 minutes ago
- File admin-bar-search.gif admin-bar-search.gif added
I've added back the search icon in the admin bar if not on the main site in https://github.com/cuny-academic-commons/cac/commit/d85e8f2f73. I've also adjusted the positioning of the search icon so it is displayed just before our Help button and added some CSS to make the search bar a little larger so it fits our larger Commons admin bar height. See attached GIF.