CUNY Academic Commons

I believe the original intention behind Group Library Docs was to allow any group member to make modifications to a Doc. However the use case brought up in Keeping about limiting doc edit access to group admins and moderators makes sense.

If we want to implement this, we would need to make some changes to the Group Library and to the buddypress-docs-in-group plugin to show some additional doc options. Boone, in vanilla BuddyPress Docs, it is possible to set the access control for each group's document:

However the buddypress-docs-in-group plugin removes the "Access" controls when creating or editing a group doc: https://github.com/boonebgorges/buddypress-docs-in-group/blob/ea686cde3da444366a2915c2886ce46e5f36503d/includes/bpdig.php#L194

Removing the Access section was probably done to simplify doc access controls within the group, but would it make sense to bring the Access block back, but adding each group membership level as an additional option? Or perhaps these access controls could be configured at the group level under a group's "Manage > Group Settings" section as well?

As it pertains to the Group Library, Group Library outputs its own version of BuddyPress Docs settings -- https://github.com/cuny-academic-commons/cac-group-library/blob/master/assets/js/app/components/Forms/BpDocForm.vue -- which would need to be modified if we wanted to add back the Access section at the individual doc level.

I'm on board with making documentation/text updates, but I'm a bit confused by the following:

As discussed in the Friday monthly meeting, we're going to hold off on a larger dev fix here, as this is likely an edge case, especially because Docs are rarely used. Instead, let's try to clarify this to users with help text / documentation.

Let's also make Docs work the same as other Library items (if I have this correct), where they can only be edited by the original uploader and group admins/moderators.

I think that we should NOT change the behavior of Docs. The whole purpose of this feature is to collaborate on a single document.

My fault. Let's use change the intro paragraph to this instead to reflect that Docs should remain editable by any group member:

You can select three different types of items to add to your Library. Files are standalone uploads from your desktop like images, PDFs or Word Docs (similar to an email attachment). External Links point to an item hosted elsewhere on the web, like Google or Dropbox. Docs are text documents that can be edited by any Group member. Files and external links can only be edited or removed by the original uploader or Group Admins and Moderators, but not by any other Group members.

Looks good to me, thanks Boone!