Feature #2478
closedEnsure that sitewide footer is responsive
Added by Matt Gold over 11 years ago. Updated over 11 years ago.
0%
Description
Please see this thread for complaints that our sitewide footer interferes with the responsiveness of responsive WP themes.
Updated by Chris Stein over 11 years ago
I'm fine with making changes to the footer to make it more responsive. However we still haven't implemented #2000 which was a change to the footer. Any changes made should be to the proposed footer from issue #2000. I'm adding Dom as a watcher to this since he was assigned to implement those changes.
I will look at those HTML and CSS files and there are probably some relatively simple changes that can be made to the CSS to make it responsive.
Updated by Boone Gorges over 11 years ago
I don't think we need to make it literally responsive with media queries. Just removing the max-width will do most of the work. (Though some media queries to make it prettier at small widths would be a bonus.)
Updated by Chris Stein over 11 years ago
Yes, I was thinking along similar lines
Updated by Boone Gorges over 11 years ago
- Status changed from Assigned to Resolved
In https://github.com/castiron/cac/commit/93b60be7ced0237580fb06d8cd55662ada50d706, I removed the min-width declaration that was causing most of the problem. I also added a few media query blocks so that things are readable on small screens. Marking as Resolved for now; feel free to reopen if you have things to add.
Updated by Matt Gold over 11 years ago
Can you please send a notification when this is on the site? Many thanks
Updated by Boone Gorges over 11 years ago
Can you please send a notification when this is on the site? Many thanks
You mean aside from the normal release announcement? http://dev.commons.gc.cuny.edu
Updated by Matt Gold over 11 years ago
You mean aside from the normal release announcement? http://dev.commons.gc.cuny.edu
Yes, I was hoping for a heads-up reminder so that I can remember to post to the help thread in question. Although, Chris, if you have time to pipe in there with a response on what we did and what we might still do, that would be preferable. Please let me know whether you have time for that.
Updated by Chris Stein over 11 years ago
I can pipe in if I see it in action. Boone, I have to apologize, but it's been too long since I've cloned the cac git and I can't remember what changes I need to make to get it working. I'll sit down again this weekend but other wise you'd have to push the changes to cdev.
Updated by Boone Gorges over 11 years ago
The change is now live. Here's a blog running Twenty Twelve: http://rbiggie.commons.gc.cuny.edu/
Note that all footer content snaps left at small sizes (and some spacing gets cleared up).
Updated by Chris Stein over 11 years ago
OK, thanks. Running out, I'll take a look at this. Also may send update with content from #2000