CUNY Academic Commons

As for the missing photos for certain groups in the Groups Directory, it looks like an Amazon S3 ACL issue as the image URLs are returning "403 Access Denied" errors when attempting to load them.

Boone, are you able to look into the broken group photos issue?

Yup, I'll have a look.

Hi Ray - I've had a look. I don't think this is an S3 issue, but instead it appears to be related to the avatar cache layer. It seems as if the avatar cache layer doesn't support the possibility that the -thumb and -full variants of the same group's avatar might have different basenames. Take this example, which belongs to group 1746 m-a-program-in-biography-and-memoir:

litespeed@node15377-cunyacprod-1 ~/public_html $ wp s3-uploads ls blogs.dir/1/files/group-avatars/1746/
5dfc12188c660-bpfull.jpg
5dfc1218a3b4f-bpthumb.jpg
BAM-450x181.jpg

Because the -bpfull and -bpthumb basenames are different, one can get poisoned by the other in the cache. In this specific example, the -bpthumb variant is cached, which breaks the full variant on the /groups/ directory:

litespeed@node15377-cunyacprod-1 ~/public_html $ wp shell
wp> groups_get_groupmeta( 1746, '_bp_avatar_url' );
=> string(123) "https://s3.amazonaws.com/files.commons.gc.cuny.edu/wp-content/blogs.dir/1/files/group-avatars/1746/5dfc1218a3b4f-bpfull.jpg" 

Note that this URL is incorrect: the hash is from the -bpthumb variant, and the -bpfull variant appears to be concatenated. The fact that you're getting a 403 is a red-herring - this is actually a 404, a case where the file doesn't exist.

I started looking at a patch for this, but I thought maybe I'd ask you to have a look first. I think the cleanest thing is just to cache the thumb and full URLs separately, but this gets a little bit hairy around the question of default avatars and Gravatar support.

It seems as if the avatar cache layer doesn't support the possibility that the -thumb and -full variants of the same group's avatar might have different basenames.

Thanks for looking into this, Boone. That makes sense. In my limited, local testing, the basenames for both full and thumb avatar versions were the same, so I thought I could get away with just caching the full version and switching the suffix for the thumb. I'll work on caching the avatar thumb URL as well for the avatar caching layer.