CUNY Academic Commons

I just came across this ticket and this is exactly what I experienced yesterday with the SPS group. I'll do some testing tonight and update this ticket accordingly.

Has there been any update on this? I got an email from a faculty member this week asking what was wrong with the updates since he got emailed 5 times on a post I edited. You can see the repeat posts/emails here: http://commons.gc.cuny.edu/groups/philosophy-562225957/ Thanks!

(And to answer your question from earlier, yes I had been deleting the repeat posts but left them up now so you can see the problem.)

Sorry, I missed this ticket.

I seem to recall that you fixed an issue in GES that prevented edited activity items from triggering additional email notifications. Is that correct? If so, can you point me toward it, so I can take a look at how it's not playing nicely with bp-groupblog?

Yes, I added a code snippet to GES that checks if an activity ID is already passed when saving an activity entry, if so, I stop GES from attempting to record / send the group email:
https://github.com/boonebgorges/buddypress-group-email-subscription/blob/master/bp-activity-subscription-functions.php#L496

I'm guessing the problem has to do with bp-groupblog not passing the original activity ID, which is why it's creating a new activity entry each time.

I'll take a closer look.

Boone, I've opened a pull request in the bp-groupblog repo, which fixes this issue.

Let me know what you think when you've taken a look.

Hi Ray & Boone! Thanks for your work on this. Although I am still having the same problem on my philosophy.commons.gc.cuny.edu site. Edits are still being treated like new posts, with emails sent out every time. See here for examples: http://commons.gc.cuny.edu/groups/philosophy-562225957/ You can see that for a number of the so-called "new" posts (CFP: Cognitive Penetration of Perception, Philosophy Department Newsletter 2012-2013, etc) small edits were made. Everyone with a group email subscription is emailed each time an edit is made. I have received complaints from faculty members about getting slammed with emails. Please let me know if I am not being clear about what the issue is. I hope we can get this sorted out soon. Thanks again!

I just took a look at the Philosophy group and it appears this is working.

The recent CAC update occurred on July 11th and since then only one post was edited:

Philosophy Teaching Resource | Enlightened Educators - http://philosophy.commons.gc.cuny.edu/philosophy-teaching-resource-enlightened-educators/

Which was edited yesterday and only one activity item exists. This item should not have been sent by the Group Email Subscription plugin. Let me know if it did.

Just to reiterate: Any edit to a blog post from July 11th and on should not result in duplicate activity entries / group emails.

I just tested this as well and it seems to be fixed, I edited a group blog post and only received one notification. It also appeared on the homepage (yay)!

Hi Ray. I see! I think I misunderstood - I thought the change was effective immediately - but it was made internally and then enacted in the July 11 update? It seems to be working perfectly now. Thanks so much for your work on this!