Move position of close window checkbox on overlay
When the browser window is small, the overlay layer goes under the admin bar and thus the close window checkbox can be hidden. I'd suggest either making the overlay appear above the admin bar or moving the checkbox. Otherwise, people may not be able to close the window and may not realize that embiggening the window will allow them to see the full overlay
Seems like this will be a particular problem on tablets and mobile devices.
#1 Updated by Chris Stein about 8 years ago
Yes, that's a problem. Next time we do an overlay I'll have to do more research and find one that fits more flexibly.
If we can move the overlay over the admin bar then great. If not then we can also add a "close window" link at the bottom of the overlay that would be a second way to close it out. It could even be placed just beneath the other text so it was more certain to be visible.
#3 Updated by Boone Gorges about 8 years ago
In https://github.com/castiron/cac/commit/5ed6a1cf10f703b7ae16b406d5c8bf8cc4333523, I change the way the modal is initialized so that it appears over the top of the admin bar, along with a couple other items that make it work better on narrow screens. It's ready to test on cdev, where I've also put a temp fix in to allow you to see the modal at anytime: append the show_overlay=1 param to any cdev URL (while logged in).
#4 Updated by Matt Gold about 8 years ago
Much better, Boone -- thank you. The window now definitely appears over the admin bar, which is great. For me, when I resized my browser window in Mac OS/Chrome, the alert window was not responsive, which meant that it was partly viewable, partly not on a narrow window. As a quick way of getting around this, I suggest we follow Chris's advice above and add a "Close Window" link at the bottom of the message itself.
#7 Updated by Boone Gorges about 8 years ago
- Status changed from Assigned to Testing Required
"Close window" link added in https://github.com/castiron/cac/commit/93486b5e0e4d4b280761425f21deb42f18ab9b4f
#8 Updated by Boone Gorges almost 8 years ago
- Target version set to 1.5.3
The "close window" link is ready to test on cdev: http://cdev.gc.cuny.edu/members/admin/?show_overlay=1