Bug #2786
closed
Move position of close window checkbox on overlay
Added by Matt Gold about 11 years ago.
Updated about 11 years ago.
Category name:
BuddyPress (misc)
Description
When the browser window is small, the overlay layer goes under the admin bar and thus the close window checkbox can be hidden. I'd suggest either making the overlay appear above the admin bar or moving the checkbox. Otherwise, people may not be able to close the window and may not realize that embiggening the window will allow them to see the full overlay
Seems like this will be a particular problem on tablets and mobile devices.
Screenshot attached.
Files
Yes, that's a problem. Next time we do an overlay I'll have to do more research and find one that fits more flexibly.
If we can move the overlay over the admin bar then great. If not then we can also add a "close window" link at the bottom of the overlay that would be a second way to close it out. It could even be placed just beneath the other text so it was more certain to be visible.
Boone, please let us know your thoughts when you have a chance. With this overlay active, I think we should address this sooner rather than later if possible.
Much better, Boone -- thank you. The window now definitely appears over the admin bar, which is great. For me, when I resized my browser window in Mac OS/Chrome, the alert window was not responsive, which meant that it was partly viewable, partly not on a narrow window. As a quick way of getting around this, I suggest we follow Chris's advice above and add a "Close Window" link at the bottom of the message itself.
It's not intended to resize dynamically. Try resizing then refreshing.
Aha -- beautiful. Nice work!! I suppose that I'd consider adding a "close window" link at the bottom just to be safe, but let me know what you think.
- Status changed from Assigned to Testing Required
- Target version set to 1.5.3
Looks good to me. Thanks.
- Status changed from Testing Required to Resolved
Also available in: Atom
PDF