Project

General

Profile

Actions
Copy link

Bug #2791

closed

Modify yellow profile bar alert

Added by Matt Gold about 11 years ago. Updated over 10 years ago.

Status:
Rejected
Priority name:
Normal
Assignee:
Chris Stein
Category name:
BuddyPress (misc)
Target version:
1.5.19
Start date:
2013-09-12
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Is there any way to move the "show message" link from the right margin over to the left, right next to the "New CUNY Academic Commons Profiles"? Think it would make more sense to have these two together.

Also, is there a way to dismiss this or are we just having it stay until we remove it globally? I think it would be good to give users a chance to delete it permanently if possible.

Files

Download all files
Screen Shot 2013-09-12 at 9.54.54 PM.png (49.7 KB) Screen Shot 2013-09-12 at 9.54.54 PM.png Matt Gold, 2013-09-12 09:55 PM
Remove-as-button.png (38 KB) Remove-as-button.png Chris Stein, 2013-09-13 09:56 PM
Remove-as-link.png (29.9 KB) Remove-as-link.png Chris Stein, 2013-09-13 09:56 PM
Remove-as-button-v2.png (33.3 KB) Remove-as-button-v2.png Chris Stein, 2014-02-12 03:33 PM
YellowBarEdits.txt (980 Bytes) YellowBarEdits.txt Chris Stein, 2014-02-12 03:34 PM
Actions
Copy link
 #2

Updated by Boone Gorges about 11 years ago

  • Status changed from Assigned to Reporter Feedback

Is there any way to move the "show message" link from the right margin over to the left, right next to the "New CUNY Academic Commons Profiles"?

Yes, do you want me to do it?

Also, is there a way to dismiss this or are we just having it stay until we remove it globally?

Yes, how do you want it to work?

Actions
Copy link
 #3

Updated by Matt Gold about 11 years ago

Happy to hear thoughts from other team members, but he's my take:

Is there any way to move the "show message" link from the right margin over to the left, right next to the "New CUNY Academic Commons Profiles"?
Yes, do you want me to do it?

Yes, that would be great. (Chris, if you disagree, please speak up)

Also, is there a way to dismiss this or are we just having it stay until we remove it globally?
Yes, how do you want it to work?

I'd just add a "Dismiss this message" link to allow people to shelve it if they choose. I think people will not realize that it only shows up for logged in users looking at their own profiles and may wonder whether it's visible to non-logged in users.

Actions
Copy link
 #4

Updated by Boone Gorges about 11 years ago

  • Status changed from Reporter Feedback to Assigned
  • Assignee changed from Boone Gorges to Chris Stein

Chris, can I ask you to do the following:

1) Confirm Matt's first request

2) Do a mockup for how the second one would look

3) Switch the ticket over to me when it's ready for implementation

Thanks!

Actions
Copy link
 #5

Updated by Chris Stein about 11 years ago

Yes, confirming 1. I want to have a way to dismiss it too and changing the position of show/hide is fine. I might change "hide" to "minimize" or something to help differentiate it from dismiss. Not at a computer now so I'll get to 2. and 3. later.

Actions
Copy link
 #6

Updated by Chris Stein about 11 years ago

I have two mockups. One is with the remove as a link and one is with it styled like a button.
The link is just adding a normal link with the color #a60200 and some padding-top:15px to move it down.
The button uses the button class and then changed the background-color:#a60200 and border color #590100 and I think some padding above to separate it a bit.

The hide button has two options. One is to change the absolute positioning to top:9px; left:310px;
The other is to move the HTML into the heading. I noticed I didn't actually make it a heading so it would be something like:
<h5>
New CUNY Academic Commons Profiles
<span class="action"><a href="#">Hide Message</a></span>
</h5>

and then give it a padding-left:15px; to move it away from the rest of the heading. This second option may be more friendly with different screen sizes and resolutions since it doesn't rely on absolute positioning.

Matt can you
  1. confirm that the Hide Message is where you were thinking
  2. give us a nod as to whether you would rather have the button or link for the remove permanently
  3. any changes you want

If you pick one option and don't need any changes then you can assign it to Boone.

Actions
Copy link
 #7

Updated by Matt Gold about 11 years ago

Thanks so much, Chris. I think that the button is a little too strong. I'd suggest going with Remove-as-link. One thought, though: can we put "hide message" and "delete permanently next to one another, since they provide proximal functions? I'd move the "hide message" link from its current position down next to "remove"

Actions
Copy link
 #8

Updated by Chris Stein about 11 years ago

Hi Matt, sorry I was unavailable this weekend. I thought about moving the hide and delete next to each other but there were a couple of reasons against. One is that I wanted the show/hide to appear on the same place. The show has to be at the top so you can see it and if you move the hide down then they would be in different places. Not a deal breaker but it seemed preferable to keep them in the same location. I also worried that it would be difficult for people on touch screens to do one and not the other. If we do it we would just have to add some extra padding to make sure we had sufficient spacing between them.

Actions
Copy link
 #9

Updated by Boone Gorges about 11 years ago

  • Target version set to 1.5.3

Time is running very short for the 1.5.3 release (I will not be available for last minute implementation). If we want this to be in 1.5.3, we'll need to finalize the plan within the next couple hours, so I can implement today.

Actions
Copy link
 #10

Updated by Matt Gold about 11 years ago

Fine to delay this if needed. And upon reflection, maybe the button (http://redmine.gc.cuny.edu/attachments/download/1086/Remove-as-button.png) isn't too garish and we should go with it. Chris, can you let us know whether you agree with that decision and whether you have time to send code today or whether we should boot to the next release? Many thanks.

Actions
Copy link
 #11

Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.5.3 to 1.5.4
Actions
Copy link
 #12

Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.5.4 to 1.5.5
Actions
Copy link
 #13

Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.5.5 to 1.5.6
Actions
Copy link
 #14

Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.5.6 to 1.5.7
Actions
Copy link
 #15

Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.5.7 to 1.5.8
Actions
Copy link
 #16

Updated by Boone Gorges about 11 years ago

  • Target version changed from 1.5.8 to 1.5.9
Actions
Copy link
 #17

Updated by Boone Gorges almost 11 years ago

  • Target version changed from 1.5.9 to 1.5.10
Actions
Copy link
 #18

Updated by Boone Gorges almost 11 years ago

  • Target version changed from 1.5.10 to 1.5.11
Actions
Copy link
 #19

Updated by Boone Gorges almost 11 years ago

  • Target version changed from 1.5.11 to 1.5.12
Actions
Copy link
 #20

Updated by Boone Gorges almost 11 years ago

  • Target version changed from 1.5.12 to 1.5.13
Actions
Copy link
 #21

Updated by Boone Gorges almost 11 years ago

  • Target version changed from 1.5.13 to 1.5.14
Actions
Copy link
 #22

Updated by Boone Gorges almost 11 years ago

  • Target version changed from 1.5.14 to 1.5.15
Actions
Copy link
 #23

Updated by Boone Gorges almost 11 years ago

  • Target version changed from 1.5.15 to 1.5.16
Actions
Copy link
 #24

Updated by Boone Gorges almost 11 years ago

  • Target version changed from 1.5.16 to 1.5.17
Actions
Copy link
 #25

Updated by Boone Gorges almost 11 years ago

  • Target version changed from 1.5.17 to 1.5.18
Actions
Copy link
 #26

Updated by Chris Stein almost 11 years ago

OK, I think it's time to put this one to bed. Sorry it's taken me so long. I'm attaching a.txt file with some changes to the HTML and CSS to achieve the layout with Hide Message next to the title (would change to Show Message on click) and a "Remove Message Permanently" button at the bottom.

I'm open to changes but think it's time we allow people to remove this.

Image attached with screenshot as well.

Actions
Copy link
 #27

Updated by Chris Stein almost 11 years ago

missed the .txt file

Actions
Copy link
 #28

Updated by Boone Gorges almost 11 years ago

  • Status changed from Reporter Feedback to Assigned

Hi Chris -

Actually, the alert can already be permanently dismissed. http://redmine.gc.cuny.edu/issues/2976 I apologize for not marking this issue as a duplicate when #2976 came through.

The change is already in production. Would you take a look to see if it's good enough? I can implement your suggestion if you think it's still necessary.

Actions
Copy link
 #29

Updated by Boone Gorges over 10 years ago

  • Target version changed from 1.5.18 to 1.5.19
Actions
Copy link
 #30

Updated by Chris Stein over 10 years ago

  • Status changed from Assigned to Rejected

OK, no problem. I'm just glad to have the functionality there so folks don't have to see that anymore. It's there, it's working, I don't see a need to do any more work on it.

Marking as rejected since we went with a similar, but different solution (change to duplicate or resolved if those more appropriate)

Actions
Copy link

Also available in: Atom PDF