Design/UX #3843: My Commons Tab Color - CUNY Academic Commons - CUNY Graduate Center - Project Tracking System

Custom queries

. 2.4.11 open
2.5.0 open
2.5.0 open (by category)
2.5.0 open (by tracker)
High Priority Issues by User
Inbox (no milestone)
My Assigned Issues (by milestone)
My Watched Issues (by milestone)
Not Tracked - grouped by assignee
Not tracked (milestone-independent)

Actions

Copy link

Design/UX #3843

closed

My Commons Tab Color

Added by Samantha Raddatz over 9 years ago. Updated over 9 years ago.

Status:

Resolved

Priority name:

Normal

Assignee:

Daniel Jones

Category name:

Design

Target version:

1.8

Start date:

2015-02-26

Due date:

% Done:

Estimated time:

Deployment actions:

Description

The My Commons tab color being blue does help differentiate it from the other tabs, but makes it unclear to users if it's part of the navigation or a label/header. It's also unclear to users when they're within the MyCommons tab because the color of the tab doesn't change.

I recommend changing the tab color to match the others, both in general and when user is using the My Commons section.

History
Notes
Property changes

Actions

Copy link

Updated by Matt Gold over 9 years ago

Maybe we should go from blue/black to white and gold

Actions

Copy link

Updated by Matt Gold over 9 years ago

Bad #TheDress jokes aside, I'm fine with what you suggest here, Sam

Actions

Copy link

Updated by Boone Gorges over 9 years ago

Category name set to Design
Assignee changed from Boone Gorges to Daniel Jones

Actions

Copy link

Updated by Daniel Jones over 9 years ago

So I can turn off the blue color pretty easily, but it'll be a little more work to get it to behave like the other tabs when it's the page users are on. It doesn't get the "current-menu-item" class added to it right now when it's the current menu item. Best I can tell it's because Buddypress uses 'actions' to figure out what the current menu item is, and My Commons isn't hooked up to an 'action'.

Is that right Boone? I think I could handle this with some of my own PHP but want to check to see if there's a way you think would be best.

Actions

Copy link

Updated by Daniel Jones over 9 years ago

Oh wait! I'm also just realizing that My Commons doesn't work on my local install, which might actually be the issue. I get a "Page not found" error when I go to it. Maybe if I was actually on the page it would work. I committed the simple CSS change I made now in case it's enough: https://github.com/cuny-academic-commons/cac/commit/fae6215c0f9d6776d38910b85e7b8ad4c8dbd025

Actions

Copy link

Updated by Boone Gorges over 9 years ago

Status changed from New to Assigned

Thanks, Dan. This doesn't appear to work, though - current state highlighting ('current-menu-item') is not working. You may need to filter something to make it work. Check out `wp_nav_menu()` for appropriate filters (and `cac_is_my_commons()` for a reliable way to check).

If you're not seeing My Commons on your installation - or really anytime you see a mismatch between your local and production that's related to the database state - you may want to check https://github.com/cuny-academic-commons/cac/wiki/Release-ACTION_REQUIRED-list. This is a list of database tasks I perform on releases. In this case, there is a task under 1.7 that you shoudl be able to reproduce locally to get things up and running.

Actions

Copy link