Bug #3986: Hidden/Private Groups and Sites Appearing Publicly - CUNY Academic Commons - CUNY Graduate Center - Project Tracking System

Actions

Copy link

Bug #3986

closed

Hidden/Private Groups and Sites Appearing Publicly

Added by Samantha Raddatz over 9 years ago. Updated over 9 years ago.

Status:

Resolved

Priority name:

Urgent

Assignee:

Boone Gorges

Category name:

Group Blogs

Target version:

1.7.18

Start date:

2015-04-10

Due date:

% Done:

Estimated time:

Deployment actions:

Description

I just edited my site map post on the CUNY Commons Redesign 2015 site (which is a site attached to a hidden group) a few minutes ago and it is appearing on the homepage even when I'm not logged in. See screenshot attached for example. My text is short enough that it's all showing on the homepage, and the PDF link is also active without login.

Related: I created a hidden group a couple weeks ago and got a Google Alert about it, in connection with my name later that day. The creation of the site also appears in my public profile activity (see attached). During testing, one of the users also mentioned that she had some panicked moments after she created a private blog but then found that it was appearing in a few different feed areas (even though no one could access it without a password, they didn't like that the public knew it existed).

Seems like there's a bug in the actions that are correlated with activity on hidden groups and private sites. Or I'm misunderstanding the implications of hiding a site or creating a private blog, and so are our users.

Files

Download all files

Screen Shot 2015-04-10 at 11.19.34 AM.png (77.2 KB) Screen Shot 2015-04-10 at 11.19.34 AM.png	Homepage 'Recent Blog Posts' feed when logged out	Samantha Raddatz, 2015-04-10 11:45 AM
Screen Shot 2015-04-10 at 11.39.01 AM.png (69.1 KB) Screen Shot 2015-04-10 at 11.39.01 AM.png	Public Activity Feed - Hidden site creation	Samantha Raddatz, 2015-04-10 11:45 AM

Actions

Copy link

Updated by Samantha Raddatz over 9 years ago

Subject changed from Hidden/Private Groups and Sites Appearing Publically to Hidden/Private Groups and Sites Appearing Publicly

Actions

Copy link

Updated by Boone Gorges over 9 years ago

Status changed from New to Reporter Feedback
Priority name changed from Normal to Urgent
Target version set to 1.7.18

Thanks, Samantha. This is due to a bug in the filter on the Recent Blog Posts widget that wasn't properly accounting for groupblog posts (as opposed to blogs that are not associated with groups). It should be fixed by https://github.com/cuny-academic-commons/cac/commit/cf396f90ea75efafb58edf8dda9e555ba27bf605. The fix is live on the production site. Can you please verify?

Actions

Copy link

Updated by Matt Gold over 9 years ago

I was about to mark this as urgent, but you had already updated the ticket and employed a fix. Huge thanks, Boone, and huge thanks to you, too, Samantha, for flagging this.

Actions

Copy link

Updated by Boone Gorges over 9 years ago

Ray, adding you as a watcher. I have disabled BP Widget Cache for the moment, as it's not clear to me whether it's caching the Recent Blog Posts widget. If so, I assume that it's not doing it on a per-user basis. Can you verify?

Actions

Copy link

Updated by Samantha Raddatz over 9 years ago

Thanks for the quick fix, Boone! Yes, it looks good now -- I just added a new post and it's not visible on the homepage when I'm not logged in.

It is visible if I'm logged in, which might make logged in users think their private post is public (since nothing else on the homepage changes when you login).

Actions

Copy link

Updated by Boone Gorges over 9 years ago

Samantha Raddatz wrote:

Thanks for the quick fix, Boone! Yes, it looks good now -- I just added a new post and it's not visible on the homepage when I'm not logged in.

It is visible if I'm logged in, which might make logged in users think their private post is public (since nothing else on the homepage changes when you login).

Cool, thanks for verifying. The behavior has been like this forever, and I can't recall ever hearing confusion about it. (You can imagine the opposite confusion too: why doesn't my post show up here?) That being said, removing non-public content from this stream would greatly simplify the implementation.

Actions

Copy link

Updated by Samantha Raddatz over 9 years ago

Boone Gorges wrote:

The behavior has been like this forever, and I can't recall ever hearing confusion about it. (You can imagine the opposite confusion too: why doesn't my post show up here?) That being said, removing non-public content from this stream would greatly simplify the implementation.

I got the sense from my user testing that people that use the Common to update and post to sites a lot hardly ever encounter the homepage, so it's likely that no one has ever noticed one way or the other. Since no other areas of the homepage are dynamic based on login, it seems safe to remove non-public events from the stream entirely. These events will still appear in the MyCommons streams for those people that are a part of the group/site, correct?

Actions

Copy link

Updated by Boone Gorges over 9 years ago

These events will still appear in the MyCommons streams for those people that are a part of the group/site, correct?

Correct. If there's no disagreement, I'll change the front page widget to show public content only.

Actions

Copy link

Updated by Raymond Hoh over 9 years ago

Ray, adding you as a watcher. I have disabled BP Widget Cache for the moment, as it's not clear to me whether it's caching the Recent Blog Posts widget.

BP Widget Cache should be caching CAC's version of the Recent Blog Posts widget:
https://github.com/cuny-academic-commons/cac/blob/1.7.x/wp-content/plugins/bp-custom.php#L265

Actions

Copy link

#10