Project

General

Profile

Actions
Copy link

Feature #5345

closed

Plus symbol problem in SP

Added by Marilyn Weber over 8 years ago. Updated over 8 years ago.

Status:
Rejected
Priority name:
Normal
Assignee:
Christian Wach
Category name:
Social Paper
Target version:
1.9.17
Start date:
2016-03-20
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Jojo Karlin writes:
"The + symbol doesn't appear beside text formatted in lists."

I reported that it would be considered for future releases. Thanks!

Actions
Copy link
 #1

Updated by Boone Gorges over 8 years ago

  • Target version set to Future release

Thanks for reporting, Marilyn. Can you provide some additional details? Does this mean that it's impossible to add multimedia in the context of a list item?

Actions
Copy link
 #2

Updated by Matt Gold over 8 years ago

I think she meant that she was unable to comment on text in a bulleted list

Actions
Copy link
 #3

Updated by Boone Gorges over 8 years ago

  • Assignee set to Raymond Hoh

Ah, I see - that makes more sense. Thanks!

This may be a configuration-level issue for Inline Comments. Ray, can you have a brief look? If it's something we can easily fix, let's do it. (I'm guessing it won't be easy.)

Actions
Copy link
 #4

Updated by Raymond Hoh over 8 years ago

It should be as simple as adding the <li> element to the Inline Comments selector. I have Social Paper's selectors hardcoded at the moment.

I'll experiment with this in 1.9.12 once that milestone is added.

Actions
Copy link
 #5

Updated by Boone Gorges over 8 years ago

  • Target version changed from Future release to 1.9.12

OK, that's good. Can you also verify that the change won't wreak havoc with Christian's code that keeps track of editor changes? I thought I recollected that an assumption was made there about <p> elements, but I could be misremembering.

Actions
Copy link
 #6

Updated by Raymond Hoh over 8 years ago

Oh crud, you're absolutely right! It will probably wreck havoc :(

Actions
Copy link
 #7

Updated by Christian Wach over 8 years ago

Hmm, yes this will be an issue as things stand. I'll have a go at making the tag name(s) generic when I get a moment.

Actions
Copy link
 #8

Updated by Boone Gorges over 8 years ago

  • Target version changed from 1.9.12 to 1.9.13
Actions
Copy link
 #9

Updated by Boone Gorges over 8 years ago

  • Target version changed from 1.9.13 to 1.9.14
Actions
Copy link
 #10

Updated by Boone Gorges over 8 years ago

  • Target version changed from 1.9.14 to 1.9.15
Actions
Copy link
 #11

Updated by Boone Gorges over 8 years ago

  • Target version changed from 1.9.15 to 1.9.16
Actions
Copy link
 #12

Updated by Christian Wach over 8 years ago

I'm keen to have a crack at this, but am in the final stages of a substantial project. I will have a go as soon as possible.

Actions
Copy link
 #13

Updated by Boone Gorges over 8 years ago

  • Assignee changed from Raymond Hoh to Christian Wach

Thanks, Christian!

Actions
Copy link
 #14

Updated by Boone Gorges over 8 years ago

  • Target version changed from 1.9.16 to 1.9.17
Actions
Copy link
 #15

Updated by Christian Wach over 8 years ago

  • Status changed from New to Rejected

I have had a decent look at the existing code and would say that this a far-from-trivial feature to implement. In the light of the discussion at the last CAC WebEx meeting, I have marked this as wontfix. If a requirement to implement this arises, please re-open.

Actions
Copy link

Also available in: Atom PDF