Project

General

Profile

Bug #5448

garbled CAC activity digests

Added by Marilyn Weber almost 3 years ago. Updated over 2 years ago.

Status:
Rejected
Priority name:
Normal
Assignee:
Category name:
Email Notifications
Target version:
Start date:
2016-04-14
Due date:
% Done:

0%

Estimated time:

Description

Katina Rogers reports:
I'm not sure whether this is a generalized issue or just something I'm experiencing, but some of my CAC activity digests have been weirdly garbled lately. This doesn't appear to be simply an issue of formatting cruft from copy/pasting from MS Word or other word processors, since the oddities are not exclusively in the user-provided content. (E.g., in the message below, "Your daily digest of group activ= ity" is unusual.)

It has happened about four times since late February on digests with content from Centers for Teaching and Learning and LACUNY. I have my GC emails pulled into gmail through POP3, but I've checked the messages on Outlook Web Access and found the same formatting issues on the messages accessed there as well. I wanted to report it in case others may be experiencing the same thing.

Best,

Katina


Katina Rogers
Deputy Director, The Futures Initiative (http://futuresinitiative.org/)
The Graduate Center
City University of New York
(212) 817-7202 | Office 3315

---------- Forwarded message ----------
From: CUNY Academic Commons <>
Date: Thu, Apr 14, 2016 at 1:03 AM
Subject: Your daily digest of group activity [CUNY Academic Commons]
To: "Rogers, Katina" <>

Your daily digest of group activ= ity at CUNY Academic Commons (http://commons.gc.cuny.edu)

Group Summary:

Group: <= a href="http://commons.gc.cuny.edu/groups/ctl/" name="ctl">Centers for = Teaching and Learning (CTL’s)

To disable these notifications fo= r this group click unsubscribe (http://commons.gc.cuny.edu/members/krogers/?=bpass-action=unsubscribe&group=290&access_key=81c31f9607ab022a07e9f16=53ae0a8eb) - change email options (https://openaccess.commons.g=c.cuny.edu/wp-login.php?action=bpnoaccess&auth=1&redirect_to=http%3A%25=2F%2Fcommons.gc.cuny.edu%2Fgroups%2Fctl%2Fnotifications%2F)

Gina Cherry (http://commons.gc.cuny.edu/members/gche=rry/) created the event Hunter “Day of DigPed” Keynote: Jack Do= ugherty, “Web Writing and Data Visualization in Liberal Arts Pedago= gy” (http://commons.gc.cuny.e=du/groups/cuny-committee-on-academic-technology-62702785/events/hunter-day-=of-digped-keynote-jack-dougherty-web-writing-and-data-visualization-in-libe=ral-arts-pedagogy/) : at 4:25 pm, April 13, 2016 – View (http://com=mons.gc.cuny.edu/events/event/hunter-day-of-digped-keynote-jack-dougherty-w=eb-writing-and-data-visualization-in-liberal-arts-pedagogy/)

=

You have received this message because yo= u are subscribed to receive a digest of activity in some of your groups on = CUNY Academic Commons.

To disable these notifications per grou= p please login and go to: My Groups (http://commons.gc.cuny.edu/members/kro=gers/groups/) where you can change your email settings for ea= ch group.


Related issues

Related to CUNY Academic Commons - Bug #5637: Email notification is somewhat garbledDuplicate2016-06-02

Has duplicate CUNY Academic Commons - Bug #5463: Weekly summary occasionally sends broken emailDuplicate2016-04-17

History

#1 Updated by Boone Gorges almost 3 years ago

Thanks for reporting this, Marilyn.

Very odd that these equals signs would be inserted, apparently at random. I'll have time to debug next week, but I'm adding Ray as a watcher here in case anything jumps out at him.

#2 Updated by Raymond Hoh almost 3 years ago

It could have something to do with the encoding of the email.

Some Google searches say it has to do with quoted-printable.

It could also be related to using the latest version of PHPMailer in WordPress:
https://github.com/PHPMailer/PHPMailer/issues/606
http://stackoverflow.com/a/34589032

#3 Updated by Boone Gorges almost 3 years ago

  • Category name set to Email Notifications
  • Status changed from New to Assigned
  • Assignee set to Raymond Hoh
  • Target version set to 1.9.15

Thanks, Ray. This is pretty lame.

I've been looking over the diff between PHPMailer 5.2.10 (last known working) and 5.2.14 (latest stable, in WP 4.4 and 4.5). I found the following lines that look related:

https://github.com/PHPMailer/PHPMailer/compare/v5.2.10...v5.2.14#diff-ace81e501931d8763b49f2410cf3094dR2109
https://github.com/PHPMailer/PHPMailer/compare/v5.2.10...v5.2.14#diff-ace81e501931d8763b49f2410cf3094dR2786

I wonder if the email encoding header is not being set correctly because of the added base64 encoding check in that first link.

I've spent some time trying to reproduce the issue with some long lines, formatted as BPGES formats them, but I've been unsuccessful. Ray, could you have a deeper look? On the off chance it's helpful, look at the file ~/wp-cli-scripts/email.php on cdev to see what I've been testing.

I'm wary to simply roll back our PHPMailer version, because of security issues in version 5.2.10. If we could reproduce the issue reliably, we may be able to determine that one of the lines linked to above is the source of the issue, in which case we could patch only those lines.

#4 Updated by Boone Gorges almost 3 years ago

  • Target version changed from 1.9.15 to 1.9.16

#5 Updated by Boone Gorges almost 3 years ago

  • Target version changed from 1.9.16 to 1.9.17

#6 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.17 to 1.9.18

#7 Updated by Raymond Hoh over 2 years ago

I tried duplicating this issue on cdev and on production, but I cannot replicate this because like Boone, everything displays correctly for me.

I think this is a problem when the recipient has a gc.cuny.edu email address, which uses Outlook / Exchange as its receiver:
https://github.com/PHPMailer/PHPMailer/issues/606#issuecomment-220627928

Can anyone else confirm if the issue only occurs for gc.cuny.edu email addresses?


I wonder if the email encoding header is not being set correctly because of the added base64 encoding check in that first link.

Someone in the same thread notes that forcing base64 encoding might work:
https://github.com/PHPMailer/PHPMailer/issues/606#issuecomment-221086183

This is probably because it skips the quoted-printable additions as Boone notes in comment 3.

However, it does sound like this is a PHPMailer problem.

Maybe we can try forcing base64 encoding if sending to a GC email address? I'll try to write some code that does this.

We might also want to try reverting these commits one at a time:
https://github.com/PHPMailer/PHPMailer/commit/6f266a2e42d63d47a37e449d187db20f053466aa (I think reverting this commit might fix things)
https://github.com/PHPMailer/PHPMailer/commit/9269a656ca2dca1ab2653c4abe7c0f796f31af33

#8 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.18 to 1.9.19

#9 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.19 to 1.9.20

#10 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.20 to 1.9.21

#11 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.21 to 1.9.22

#12 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.22 to 1.9.24

#13 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.24 to 1.9.25

#14 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.25 to 1.9.26

#15 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.26 to 1.9.27

#16 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.27 to 1.9.28

#17 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.28 to 1.9.29

#18 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.29 to 1.9.30

#19 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.30 to 1.9.31

#20 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.31 to 1.9.32

#21 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.9.32 to 1.10.1

#22 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.10.1 to 1.10.2

#23 Updated by Raymond Hoh over 2 years ago

  • Status changed from Assigned to Rejected

Given that we're now using the new BuddyPress email system for digests, let's close this until the problem resurfaces.

If we're still getting garbled activity digests, please reopen.

Also available in: Atom PDF