Project

General

Profile

Bug #6542

Feature #2049: Rich-text forum posts

Embedded image's caption is not rendering - Commons 1.10 testing

Added by scott voth almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Group Forums
Target version:
Start date:
2016-10-30
Due date:
% Done:

0%

Estimated time:

Description

When I embed a picture into a forum post (from an image's URL in file repo) - the picture comes out perfectly, and size can be changed, but the caption's html is not rendered.

see http://commons.gc.cuny.edu/groups/test-group-1761529915/forum/topic/rich-text-test/#post-50968

History

#1 Updated by Boone Gorges almost 3 years ago

  • Target version set to 1.10

#2 Updated by Boone Gorges almost 3 years ago

  • Category name set to Group Forums
  • Status changed from New to Assigned
  • Assignee changed from Boone Gorges to Raymond Hoh

Ray, can we safely process shortcodes inside of forum content, or is it wiser to be more targeted, and process just [caption]?

#3 Updated by Boone Gorges almost 3 years ago

  • Parent task set to #2049

#4 Updated by Raymond Hoh almost 3 years ago

So the interesting thing here is bbPress doesn't support the [caption] shortcode in their content either.

If you view the post that Scott made:
http://commons.gc.cuny.edu/groups/test-group-1761529915/forum/topic/rich-text-test/#post-50968

The caption shortcode is not rendered.

I think for "feature" parity, we remove the "Image Caption" box from the TinyMCE Image button and call it a day. Commit fc3c2d6 does this and is available on cdev for testing.

What does everyone think?

#5 Updated by Matt Gold almost 3 years ago

Hi Ray -- thanks for this. My only concern about your proposed path is that it leads to an accessibility issue where people using screenreaders might not be able to tell what the image displays. Can you see any way around that issue?

#6 Updated by Boone Gorges almost 3 years ago

I don't believe that captions are an accessibility feature specifically. WordPress's caption feature just wraps the text in p and div tags that aren't semantically related to the image itself. Screenreaders look at the image's alt text, which is set separately.

Removing the caption seems like the right short-term solution.

#7 Updated by Matt Gold almost 3 years ago

Thanks, Boone. Does that mean that it is currently possible to include alt text for images in forum posts?

#8 Updated by Boone Gorges almost 3 years ago

Thanks, Boone. Does that mean that it is currently possible to include alt text for images in forum posts?

Yes, that's what the "Description" field does.

#9 Updated by Matt Gold almost 3 years ago

great -- thank you. then no issue from me in moving forward as suggested above

#10 Updated by Boone Gorges almost 3 years ago

  • Status changed from Assigned to Resolved

Sounds good to me. Thanks!

Also available in: Atom PDF