Bug #725: BP Group Email Subscription - Double notifications - CUNY Academic Commons - CUNY Graduate Center - Project Tracking System

Actions

Copy link

Bug #725

closed

BP Group Email Subscription - Double notifications

Added by Raymond Hoh almost 13 years ago. Updated almost 13 years ago.

Status:

Resolved

Priority name:

Normal

Assignee:

Boone Gorges

Category name:

BuddyPress (misc)

Target version:

1.2.1

Start date:

2011-04-29

Due date:

% Done:

Estimated time:

Deployment actions:

Description

Initially reported by Matt here:
http://redmine.gc.cuny.edu/issues/show/661#note-16

If you're the author of an activity update within a group and you have your group email set to "All Mail", if someone replies to your activity update you will receive two emails - one from BP Group Email subscription and one from BuddyPress.

A way to workaround this is to temporarily set the activity update author's "*notification_activity_new_reply*" user meta setting to "no" during the group email send.

Boone, do you have any other ideas?

Actions

Copy link

Updated by Boone Gorges almost 13 years ago

Good catch.

I'd say that a better fix is for BP Group Email Sub to check to see whether you've got notification_activity_new_reply set before sending an email to you. The only trick will be to get the user_id of the activity being responded to.

Does that sound reasonable? If so, feel free to work up a patch - or I can do it myself.

Actions

Copy link

Updated by Raymond Hoh almost 13 years ago

Boone Gorges wrote:

I'd say that a better fix is for BP Group Email Sub to check to see whether you've got notification_activity_new_reply set before sending an email to you. The only trick will be to get the user_id of the activity being responded to.

I guess the better question is do we want to stop the built-in BuddyPress notification or the one from the Group Email plugin?

The latter is easier (which is the method you recommend). When I originally posted this ticket, it was to cancel the BuddyPress one. However, stopping the built-in BuddyPress one (while allowing the Group Email send) will require a bit of hackery.

Actions

Copy link

Updated by Boone Gorges almost 13 years ago

Status changed from New to Resolved
Assignee changed from Raymond Hoh to Boone Gorges

I guess the better question is do we want to stop the built-in BuddyPress notification or the one from the Group Email plugin?

Right - I was implying that we should favor the BP-native notification. Since bp_activity_new_comment_notification() is called directly, not via a hook, it would require (as you say) some ugly hackery to make it work right.

I opted to fix BPGES so that it would bail when BP-native notifications are enabled. Fixed in https://github.com/castiron/cac/commit/d0282f024bcc4cf95bc6e64bd710a3f8f22f004e Thanks for talking through it, Ray.

Actions

Copy link