Project

General

Profile

Bug #8943

RBE email attachment not posted from new topic email address

Added by Matt Gold over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Reply By Email
Target version:
Start date:
2017-11-28
Due date:
% Done:

0%

Estimated time:

Description

Hi Ray,

I can't remember whether you've implemented error messages on RBE posts with attachments, but I created a new topic via email, and the email had an attachment that did not post. I did not receive an error message. Here is the post: https://commons.gc.cuny.edu/groups/gc-digital-fellows/forum/topic/fwd-fw-call-for-proposals-for-cuny-accessiiblity-conference/

As an FYI, I have attached the attachment to this ticket


Related issues

Related to CUNY Academic Commons - Bug #9066: RBE error email not firing for new topics when attachment is too largeResolved2018-01-08

History

#1 Updated by Raymond Hoh over 4 years ago

  • Target version set to 1.12.3

Ahh, good catch.

Attachments will work when replying, but not posting a new topic at the moment. The reason is I only implemented attachments in IMAP mode and not Inbound Mode, which is what is powering the RBE custom email address for new topics.

I hope to have something for the next maintenance release on Tuesday.

#2 Updated by Raymond Hoh over 4 years ago

  • Subject changed from RBE email attachment not posted, no error message to RBE email attachment not posted from new topic email address

#3 Updated by Matt Gold over 4 years ago

Okay -- thanks!

#4 Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.12.3 to 1.12.4

#5 Updated by Raymond Hoh over 4 years ago

Edit: Sorry wrong ticket! I'm about to push a fix for this, but Boone, let me know if I'm too late for 1.12.4.

Ran out of time on this one.

#6 Updated by Raymond Hoh over 4 years ago

  • Target version changed from 1.12.4 to 1.12.5

I'm about to push a fix for this, but Boone, let me know if I'm too late for 1.12.4.

Ugh, form autofill!

#7 Updated by Boone Gorges over 4 years ago

ha ha :) The release will go out in about 15 minutes, if you still want to sneak something in...

#8 Updated by Raymond Hoh over 4 years ago

Sorry for missing the dev call. Didn't set my alarm and completely overslept!

As for an update here, I have code that is working and will have something to commit by tomorrow. Just cleaning up the code and testing IMAP to see if I didn't break anything on that end.

I decided to write a new supplementary plugin for this since the code will be using a 3rd-party email parser requiring PHP 5.4+ and RBE currently supports PHP 5.2. Here's a link to the library I'll be using - https://github.com/bashkarev/email

I'll definitely have this ready for next week's maintenance release.

#9 Updated by Raymond Hoh over 4 years ago

  • Status changed from Assigned to Staged for Production Release

I've made some changes to RBE - https://github.com/cuny-academic-commons/cac/commit/a02a716f8ab57a965d30a506c95294b84614bcd7

And created a new plugin for this functionality here.

Plugin added to 1.12.x branch - https://github.com/cuny-academic-commons/cac/commit/2eeaf967dac9f6fd0e3bb34a5ca4d9a3edd1ed4a

I rogue-tested this lightly on NYCDH on Friday and it worked.

Boone: I've updated the ACTION_REQUIRED page.

#10 Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.12.5 to 1.12.6

#11 Updated by Boone Gorges over 4 years ago

  • Status changed from Staged for Production Release to Resolved

Oops, I forgot to activate after the 1.12.5 release. I've just done so.

#12 Updated by Raymond Hoh over 4 years ago

  • Status changed from Resolved to Assigned

Thanks for activating, Boone.

Just did a quick test and it appears attachments for new topics created via email address isn't working on the Commons.

Due to the nature of the plugin, I'm going to have to do some live debugging to figure out what is wrong.

#13 Updated by Raymond Hoh over 4 years ago

  • Status changed from Assigned to Resolved

Added a hotfix on production - https://github.com/cuny-academic-commons/cac/commit/f261ddb5b3940ac2ccd9bcfa105119c46ad61a67

Just tested by creating a new topic via email address with an email attachment and it works now.

#14 Updated by Matt Gold over 4 years ago

that's great! Thank you, Ray!!

#15 Updated by Raymond Hoh over 4 years ago

  • Related to Bug #9066: RBE error email not firing for new topics when attachment is too large added

Also available in: Atom PDF