Project

General

Profile

Feature #11517

wp-accessibility plugin should not strip 'target="_blank"' by default

Added by Boone Gorges about 2 years ago. Updated almost 2 years ago.

Status:
Assigned
Priority name:
Normal
Assignee:
Category name:
-
Target version:
Start date:
2019-06-04
Due date:
% Done:

0%

Estimated time:

Description

The default setting of wp-accessibility is to strip 'target="_blank"' from links. See #11512, #11002.

In #11512, Gina suggests that this should not be the default behavior:

Since the plugin appears to insert such a warning in the HTML, would it be possible to configure it so that it does not default to removing the target attribute from links? Removing the target attribute is likely to be confusing for other users of the Teaching template.

I personally am not a fan of target="_blank". See https://redmine.gc.cuny.edu/issues/10712#note-2 and follow-up conversation. Moreover, I'm not a huge fan of messing with the default settings of third-party plugins, because it complicates updates and puts us out of step with their documentation, etc. But if others feel strongly that the current behavior is potentially confusing, it's probably possible to change the default behavior, either globally or in the case of the Teaching Template only.

I'm assigning this to Laurie as she's been the point person for building these templates, but general feedback is welcome.


Related issues

Related to CUNY Academic Commons - Bug #11512: Links not opening in new tabDuplicate2019-06-03

Related to CUNY Academic Commons - Support #11002: open link in a new tab not workingResolved2019-01-24

History

#1 Updated by Boone Gorges about 2 years ago

  • Related to Bug #11512: Links not opening in new tab added

#2 Updated by Boone Gorges about 2 years ago

#3 Updated by Matt Gold about 2 years ago

I personally am not a fan of target="_blank". See https://redmine.gc.cuny.edu/issues/10712#note-2 and follow-up conversation. Moreover, I'm not a huge fan of messing with the default settings of third-party plugins, because it complicates updates and puts us out of step with their documentation, etc. But if others feel strongly that the current behavior is potentially confusing, it's probably possible to change the default behavior, either globally or in the case of the Teaching Template only.

I agree with you, Boone, on both counts. The other option would be to remove WP-Accessibility from the teaching package, but I don't think that's a good option, either. So my take would be that we should try to address this in documentation as an initial.

I do think that the kinds of users who want to use Target=_blank are likely advanced users and will get in touch if they find that it is not working.

If this becomes an issue that a lot of users contact us about, we may want to consider as a next step a more intrusive notification when people first hit the dashboard, telling them that WP-Accessibiility is enabled, that some expected behaviors may be changed as a result, and that they can visit documentation to learn more.

#4 Updated by Gina Cherry about 2 years ago

That makes sense to me, Matt (though I might characterize the kinds of users who would choose to open links in a new window as "intermediate"). Are there other expected behaviors that WP-Accessibility changes? I think it would be very helpful to have a documented list of these behaviors.

Speaking of documentation, it would also be helpful to have additional information about the other plugins in the Teaching template. The help page for the template currently contains minimal information: https://help.commons.gc.cuny.edu/teaching-template/

#5 Updated by Sonja Leix about 2 years ago

Boone Gorges wrote:

I personally am not a fan of target="_blank". See https://redmine.gc.cuny.edu/issues/10712#note-2 and follow-up conversation. Moreover, I'm not a huge fan of messing with the default settings of third-party plugins, because it complicates updates and puts us out of step with their documentation, etc. But if others feel strongly that the current behavior is potentially confusing, it's probably possible to change the default behavior, either globally or in the case of the Teaching Template only.

I agree with this. target="_blank" is a behavior a lot of people are used to using, but it doesn't align with Accessibility standards. It always takes a while for users to readjust their mental model to a standardized behavior like this. I would advocate to keep the accessibility plugin with it's defaults active and to not make any exceptions unless it's clearly marked with the link as per accessibility standards. I agree that starting with adding these behaviors we've determined as default to the documentation.

#6 Updated by Boone Gorges almost 2 years ago

  • Status changed from New to Assigned
  • Target version set to Not tracked

Based on the above, I'm going to make the call that perhaps this is a documentation task.

#7 Updated by Laurie Hurson almost 2 years ago

I will plan to add this into the upgrade on the "Teaching on the Commons" Site as part of an overview and documentation of the teaching template.

Also available in: Atom PDF