Project

General

Profile

Actions

Bug #11865

closed

Site name not appearing in "Membership" lists of Invitation modal

Added by Marilyn Weber over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Onboarding
Target version:
Start date:
2019-09-16
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

When I'm in the Dashboard and go to invite anew user, the invite interface doesn't populate the site list with the name of the group I'm inviting from (see attached). This began a few days ago, but I thought the site names weren't there because the sites weren't public. But right now I'm inviting to Colin to the https://cpcp.commons.gc.cuny.edu/ which is public. So I'm stumped!


Files

no site name.JPG (55.2 KB) no site name.JPG Marilyn Weber, 2019-09-16 06:42 PM
still no site name.JPG (47.5 KB) still no site name.JPG Marilyn Weber, 2019-09-16 06:43 PM
email.png (60.8 KB) email.png Colin McDonald, 2019-09-16 06:54 PM
invites.png (102 KB) invites.png Colin McDonald, 2019-09-16 06:54 PM
Screenshot_2019-09-17_15-16-42.png (50.6 KB) Screenshot_2019-09-17_15-16-42.png Boone Gorges, 2019-09-17 11:16 AM
Chrome config.JPG (137 KB) Chrome config.JPG Marilyn Weber, 2019-09-17 11:02 PM
Actions #1

Updated by Colin McDonald over 4 years ago

Just jumping in to say I'm seeing the blank site field on my end as the invited user. See attached for what I saw in my email notification and on the Commons invite screen.

Actions #2

Updated by Boone Gorges over 4 years ago

  • File Screenshot_2019-09-17_15-16-42.png Screenshot_2019-09-17_15-16-42.png added
  • Tracker changed from Support to Bug
  • Subject changed from a tiny quirk in the invite system to Site name not appearing in "Membership" lists of Invitation modal
  • Category name set to Onboarding
  • Status changed from New to Reporter Feedback
  • Assignee set to Boone Gorges
  • Target version set to 1.15.10

Thanks for the report.

I've attempted to reproduce with a couple different user accounts but have not been able to do it.

Marilyn, you can help me to track down the issue by collecting some data for me. Open your browser's developer tools, and figure out how to view AJAX (XHR) requests, probably a sub-option in the Network tab. Look for one that goes to an endpoint called 'app-config', and copy the response for me. It will look something like this: {"inviteableItems":{"group":{"649":{"id":649,"name":"abcdest","roles":["member"]},"782":{"id":782,"name":"afq","roles":["member"]}},"site":{"82":{"id":82,"name":"boone's party","roles":["subscriber","contributor","author","editor","administrator"]}}},"inviteableItemIds":{"group":[649,782],"site":[82]}} (yours will likely be much, much longer because you are a member of so many sites). I've attached a screenshot of what this looks like in Chrome; it's similar in Firefox.

What Colin sees is likely a consequence of Marilyn's underlying issue.

I have an intuition that this is linked to Marilyn's account, and the fact that she's an admin on so many sites, but I'll need the info above to make further guesses.

Actions #3

Updated by Marilyn Weber over 4 years ago

Screenshot attached - much messier than yours, and has config but not app-config. Right hand columns don't look like yours at all. I use a PC, is that why? Standing by for further instructions.

Actions #4

Updated by Boone Gorges over 4 years ago

Sorry for not being clearer - app-config will only show up on this panel after you've clicked Users > Add New. Visit https://cpcp.commons.gc.cuny.edu/wp-admin/, open the Developer Tools to the Network tab, then click Users > Add New in the WP navigation.

Once you see it in the Network panel, click it. This will show you the subtabs like you see in my screenshot.

Actions #5

Updated by Marilyn Weber over 4 years ago

Ok:

{"inviteableItems":{"group":{"24":{"id":24,"name":"CUNY Academic Commons Subcommittee","roles":["member"]},"55":{"id":55,"name":"CUNY Pie","roles":["member"]},"100":{"id":100,"name":"Test hidden group","roles":["member"]},"210":{"id":210,"name":"The Group for Group Admins","roles":["member","mod","admin"]},"278":{"id":278,"name":"CUNY Assessment Council","roles":["member"]},"358":{"id":358,"name":"The WAC Resource Center","roles":["member","mod","admin"]},"465":{"id":465,"name":"CUNY Academic Commons Team","roles":["member"]},"648":{"id":648,"name":"PhD Program in History","roles":["member","mod","admin"]},"706":{"id":706,"name":"Provost\u2019s Digital Innovation Grant Recipients","roles":["member"]},"790":{"id":790,"name":"Oakes Workshop","roles":["member","mod","admin"]},"833":{"id":833,"name":"Fall \u201913 PhD Seminar in American History","roles":["member","mod","admin"]},"857":{"id":857,"name":"Announcements","roles":["member"]},"1015":{"id":1015,"name":"CUNY Commons Redesign 2015","roles":["member"]},"1044":{"id":1044,"name":"Introduction to Literary Studies (English 252) at Hunter College","roles":["member","mod","admin"]},"1100":{"id":1100,"name":"Marilyn test group","roles":["member","mod","admin"]},"1133":{"id":1133,"name":"Oakes Dissertation Seminar","roles":["member","mod","admin"]},"1149":{"id":1149,"name":"Amazing Testing Committee","roles":["member"]},"1201":{"id":1201,"name":"John Jay Online-Digital Teaching Seminar 2016-17","roles":["member","mod","admin"]},"1202":{"id":1202,"name":"John Jay Practical Teaching Seminar 2016-17","roles":["member","mod","admin"]},"1233":{"id":1233,"name":"Spring 2017 Foundations of Bilingual Ed at Hunter","roles":["member"]},"1242":{"id":1242,"name":"Anderst Fall 2017 Course Group","roles":["member","mod","admin"]},"1263":{"id":1263,"name":"York College Department of English","roles":["member","mod","admin"]},"1281":{"id":1281,"name":"Fall 2017 Foundations of Bilingual Ed at Hunter","roles":["member"]},"1287":{"id":1287,"name":"Great Digs Fall 2017 \u2013 MALS 74500","roles":["member","mod","admin"]},"1295":{"id":1295,"name":"Planning with Parents at Risk of Removal, Fall 2017, CUNY School of Law, Prof. Joe Rosenberg","roles":["member","mod","admin"]},"1305":{"id":1305,"name":"xxxxxxxxxxxxxxxx","roles":["member","mod","admin"]},"1314":{"id":1314,"name":"Teaching On The Commons","roles":["member"]},"1327":{"id":1327,"name":"Connected CUNY Planning Teams","roles":["member","mod","admin"]},"1353":{"id":1353,"name":"GC WAC Documents","roles":["member","mod","admin"]},"1408":{"id":1408,"name":"BMCC Commons Teaching Fellows: Summer 2018","roles":["member"]},"1485":{"id":1485,"name":"ITP Core 2 Course Planning","roles":["member"]},"1496":{"id":1496,"name":"Foundations of American Literature - English 75000","roles":["member","mod","admin"]},"1540":{"id":1540,"name":"mwtest3","roles":["member","mod","admin"]},"1551":{"id":1551,"name":"ELL101: Introduction to Language FA2019","roles":["member","mod","admin"]},"1589":{"id":1589,"name":"FIQWS Composition for Truth, Fiction, Photography HA3S19","roles":["member","mod","admin"]},"1602":{"id":1602,"name":"MarilynExtralongNameGroup","roles":["member","mod","admin"]},"1610":{"id":1610,"name":"Spring 2019 Critical University Studies Seminar","roles":["member","mod","admin"]},"1617":{"id":1617,"name":"notificationtest","roles":["member","mod","admin"]},"1649":{"id":1649,"name":"mwexplanatory","roles":["member","mod","admin"]},"1746":{"id":1746,"name":"M.A. Program in Biography and Memoir","roles":["member","mod","admin"]},"1748":{"id":1748,"name":"gcwritingcenter","roles":["member","mod","admin"]}},"site":{"1":{"id":1,"name":"CUNY Academic Commons","roles":["subscriber","contributor","author","editor","administrator"]},"115":{"id":115,"name":"OLD Help","roles":["subscriber","contributor","author","editor","administrator"]},"276":{"id":276,"name":"Le Hub","roles":["subscriber","contributor","author","editor","administrator"]},"313":{"id":313,"name":"Information Literacy CUNY","roles":["subscriber","contributor","author","editor","administrator"]},"379":{"id":379,"name":"Help & Support","roles":["subscriber","contributor","author","editor","administrator"]},"389":{"id":389,"name":"Ground Control","roles":["subscriber","contributor","author","editor","administrator"]},"604":{"id":604,"name":"Graduate Student Organization (GSO) at the Hunter-Bellevue School of Nursing","roles":["subscriber","contributor","author","editor","administrator"]},"643":{"id":643,"name":"Brooklyn Waterfront Research Center","roles":["subscriber","contributor","author","editor","administrator"]},"773":{"id":773,"name":"CUNY School of Professional Studies Writing Fellows","roles":["subscriber","contributor","author","editor","administrator"]},"1011":{"id":1011,"name":"Committee on Globalization and Social Change","roles":["subscriber","contributor","author","editor","administrator"]},"1013":{"id":1013,"name":"The Committee for the Study of Religion","roles":["subscriber","contributor","author","editor","administrator"]},"1109":{"id":1109,"name":"","roles":["subscriber","contributor","author","editor","administrator"]},"1120":{"id":1120,"name":"GC Digital Fellows","roles":["subscriber","contributor","author","editor","administrator"]},"1165":{"id":1165,"name":"Ph.D. Program in History Commons Site","roles":["subscriber","contributor","author","editor","administrator"]},"1185":{"id":1185,"name":"I L E T C","roles":["subscriber","contributor","author","editor","administrator"]},"1243":{"id":1243,"name":"YCRadio.Org","roles":["subscriber","contributor","author","editor","administrator"]},"1266":{"id":1266,"name":"Meena Alexander","roles":["subscriber","contributor","author","editor","administrator"]},"1334":{"id":1334,"name":"CUNY's Office of Institutional & Policy Research Wiki","roles":["subscriber","contributor","author","editor","administrator"]},"1425":{"id":1425,"name":"The Synagogue of Dura Europos","roles":["subscriber","contributor","author","editor","administrator"]},"1515":{"id":1515,"name":"Gail Levin","roles":["subscriber","contributor","author","editor","administrator"]},"1517":{"id":1517,"name":"Advanced Research Collaborative Commons","roles":["subscriber","contributor","author","editor","administrator"]},"1592":{"id":1592,"name":"Test Course Site","roles":["subscriber","contributor","author","editor","administrator"]},"1599":{"id":1599,"name":"SWIP-Analytic, Society for Women in Philosophy","roles":["subscriber","contributor","author","editor","administrator"]},"1753":{"id":1753,"name":"Commons Use Cases","roles":["subscriber","contributor","author","editor","administrator"]},"1786":{"id":1786,"name":"ACERT","roles":["subscriber","contributor","author","editor","administrator"]},"1870":{"id":1870,"name":"Test Hidden group","roles":["subscriber","contributor","author","editor","administrator"]},"2030":{"id":2030,"name":"CUNY WAC Resources","roles":["subscriber","contributor","author","editor","administrator"]},"2043":{"id":2043,"name":"PhD Program in Latin American, Iberian and Latino Cultures","roles":["subscriber","contributor","author","editor","administrator"]},"2045":{"id":2045,"name":"New Labor Forum","roles":["subscriber","contributor","author","editor","administrator"]},"2071":{"id":2071,"name":"CAC Team Group Blog","roles":["subscriber","contributor","author","editor","administrator"]},"2080":{"id":2080,"name":"Sujatha Fernandes","roles":["subscriber","contributor","author","editor","administrator"]},"2494":{"id":2494,"name":"Marilyns test group","roles":["subscriber","contributor","author","editor","administrator"]},"2510":{"id":2510,"name":"M.A. in Liberal Studies Alumni Site","roles":["subscriber","contributor","author","editor","administrator"]},"2547":{"id":2547,"name":"D\u00e9j\u00e0 Vu: Contemporary Art About Modernist Architecture","roles":["subscriber","contributor","author","editor","administrator"]},"2575":{"id":2575,"name":"Disability Studies and Nineteenth Century British Literature","roles":["subscriber","contributor","author","editor","administrator"]},"2612":{"id":2612,"name":"History Faculty Membership 2016","roles":["subscriber","contributor","author","editor","administrator"]},"2789":{"id":2789,"name":"Office of Admissions; The Graduate Center, CUNY","roles":["subscriber","contributor","author","editor","administrator"]},"2935":{"id":2935,"name":"Help","roles":["subscriber","contributor","author","editor","administrator"]},"3004":{"id":3004,"name":"Medieval Studies","roles":["subscriber","contributor","author","editor","administrator"]},"3005":{"id":3005,"name":"SLU Writing Center","roles":["subscriber","contributor","author","editor","administrator"]},"3027":{"id":3027,"name":"American Studies Certificate Program","roles":["subscriber","contributor","author","editor","administrator"]},"3138":{"id":3138,"name":"York College English Department News","roles":["subscriber","contributor","author","editor","administrator"]},"3159":{"id":3159,"name":"Academic Affairs | CUNY SPH","roles":["subscriber","contributor","author","editor","administrator"]},"3438":{"id":3438,"name":"Connected CUNY planning teams","roles":["subscriber","contributor","author","editor","administrator"]},"3454":{"id":3454,"name":"Joseph van der Naald","roles":["subscriber","contributor","author","editor","administrator"]},"3494":{"id":3494,"name":"Connected CUNY Planning Teams","roles":["subscriber","contributor","author","editor","administrator"]},"3539":{"id":3539,"name":"The Wellness Center","roles":["subscriber","contributor","author","editor","administrator"]},"3626":{"id":3626,"name":"jatest","roles":["subscriber","contributor","author","editor","administrator"]},"3649":{"id":3649,"name":"Reading Cities ","roles":["subscriber","contributor","author","editor","administrator"]},"3727":{"id":3727,"name":"Trans-Atlantic Digital Archive, Lehman College Spring 2018","roles":["subscriber","contributor","author","editor","administrator"]},"3745":{"id":3745,"name":"LAILAC","roles":["subscriber","contributor","author","editor","administrator"]},"3989":{"id":3989,"name":"Academic Affairs | CUNY SPH","roles":["subscriber","contributor","author","editor","administrator"]},"4027":{"id":4027,"name":"Journal of Teaching Disability Studies","roles":["subscriber","contributor","author","editor","administrator"]},"4035":{"id":4035,"name":"Hunter SEEK Summer Bridge Writing","roles":["subscriber","contributor","author","editor","administrator"]},"4119":{"id":4119,"name":"The Many Faces of Liberalism Conference","roles":["subscriber","contributor","author","editor","administrator"]},"4188":{"id":4188,"name":"Hist 75800 with Professor Kessner","roles":["subscriber","contributor","author","editor","administrator"]},"4431":{"id":4431,"name":"","roles":["subscriber","contributor","author","editor","administrator"]},"5007":{"id":5007,"name":"hopeimtesting","roles":["subscriber","contributor","author","editor","administrator"]},"5144":{"id":5144,"name":"Rivka Salhanick","roles":["subscriber","contributor","author","editor","administrator"]},"5320":{"id":5320,"name":"#FuturePanther Blog ","roles":["subscriber","contributor","author","editor","administrator"]},"5768":{"id":5768,"name":"Jack Wang CCNY Portfolio","roles":["subscriber","contributor","author","editor","administrator"]},"5770":{"id":5770,"name":"Justin Yulo's Digital Portfolio","roles":["subscriber","contributor","author","editor","administrator"]},"6102":{"id":6102,"name":"sillytest","roles":["subscriber","contributor","author","editor","administrator"]},"6253":{"id":6253,"name":"Rezwana Kabita's Writing for Engineering Portfolio ","roles":["subscriber","contributor","author","editor","administrator"]},"6423":{"id":6423,"name":"ELL101: Introduction to Language FA2019","roles":["subscriber","contributor","author","editor","administrator"]},"6428":{"id":6428,"name":"examplecourse","roles":["subscriber","contributor","author","editor","administrator"]},"6464":{"id":6464,"name":"Teaching on the Commons Hunter (Spr19)","roles":["subscriber","contributor","author","editor","administrator"]},"6471":{"id":6471,"name":"The Divine Comedy in English (Hunter College Spring 2019)","roles":["subscriber","contributor","author","editor","administrator"]},"6476":{"id":6476,"name":"Critical University Studies Seminar - Brier","roles":["subscriber","contributor","author","editor","administrator"]},"6540":{"id":6540,"name":"Envisioning the Body","roles":["subscriber","contributor","author","editor","administrator"]},"6551":{"id":6551,"name":"marilyncourse","roles":["subscriber","contributor","author","editor","administrator"]},"6556":{"id":6556,"name":"English 201-0701 Spring 2019","roles":["subscriber","contributor","author","editor","administrator"]},"6577":{"id":6577,"name":"MarilynExtralongNameGroup","roles":["subscriber","contributor","author","editor","administrator"]},"6705":{"id":6705,"name":"Changing Our Environment","roles":["subscriber","contributor","author","editor","administrator"]},"6813":{"id":6813,"name":"marilyncourse2","roles":["subscriber","contributor","author","editor","administrator"]},"6867":{"id":6867,"name":"marportfolio2","roles":["subscriber","contributor","author","editor","administrator"]},"6877":{"id":6877,"name":"notificationtest","roles":["subscriber","contributor","author","editor","administrator"]},"7259":{"id":7259,"name":"Teaching Writing at John Jay College","roles":["subscriber","contributor","author","editor","administrator"]},"7386":{"id":7386,"name":"English for Engineers Spring 2019","roles":["subscriber","contributor","author","editor","administrator"]},"7813":{"id":7813,"name":"mwportfolio","roles":["subscriber","contributor","author","editor","administrator"]},"8070":{"id":8070,"name":"mwexplanatory","roles":["subscriber","contributor","author","editor","administrator"]},"8071":{"id":8071,"name":"Invasive Species","roles":["subscriber","contributor","author","editor","administrator"]},"8159":{"id":8159,"name":"Women and Law Summer 2019","roles":["subscriber","contributor","author","editor","administrator"]},"8418":{"id":8418,"name":"The Progressive Era to World War II, 1900-1940: The Contours of Reform","roles":["subscriber","contributor","author","editor","administrator"]},"8573":{"id":8573,"name":"Event Site for the M.A. Program in Biography and Memoir Community","roles":["subscriber","contributor","author","editor","administrator"]},"8642":{"id":8642,"name":"","roles":["subscriber","contributor","author","editor","administrator"]},"8647":{"id":8647,"name":"The Center for Place Culture and Politics","roles":["subscriber","contributor","author","editor","administrator"]}}},"inviteableItemIds":{"group":[1149,1242,857,1408,24,465,278,1015,55,1327,1551,1589,1281,833,1496,1353,1287,1485,1044,1201,1202,1746,1100,1602,1133,790,648,1295,706,1233,1610,1314,100,210,358,1263,1748,1649,1540,1617,1305],"site":[8642,4431,1109,5320,1786,3989,3159,1517,3027,643,2071,1,773,2030,1334,6705,1011,1753,3494,3438,6476,2575,2547,6423,6556,7386,6540,8573,1120,1515,604,389,2935,379,4188,2612,4035,1185,313,8071,5768,3454,4027,5770,3745,276,2510,6577,2494,3004,1266,2045,115,2789,1165,2043,3649,6253,5144,3005,1599,2080,7259,6464,1592,1870,8647,1013,6471,4119,8418,1425,3539,3727,8159,1243,3138,6428,5007,3626,6551,6813,6867,8070,7813,6877,6102]}}

Is that it?

Actions #6

Updated by Boone Gorges over 4 years ago

That's it!

Scanning the list, I only see about three or four sites that don't have the name provided in this data. Can you confirm that this what you're seeing in the modal? If so, the sole source of the error must be in the data being assembled on the server. If not - that is, if you're seeing many more sites with blank names in the modal - then there must be more than one problem happening here.

Actions #7

Updated by Marilyn Weber over 4 years ago

And I guess my first step should be to remove myself from sites I don't need to admin on? Good grief! I swear I did that last year, but it's gotten way out of hand!

Actions #8

Updated by Marilyn Weber over 4 years ago

Yes, I see three or four in the modal

Actions #9

Updated by Boone Gorges over 4 years ago

Sure, if you can easily remove yourself, feel free :)

Thanks for the confirmation. I'll spend time this week looking more closely at the specific sites that are showing up blank.

Actions #10

Updated by Boone Gorges over 4 years ago

  • Status changed from Reporter Feedback to Staged for Production Release

I've tracked down the problem. Some sites on the Commons have an empty 'blogname' option. I have never seen this before, and I didn't think it was possible, but I guess maybe some sites do this because they don't want the theme to show the blog title (they use an image logo instead, maybe). I've made a modification so that the invitation modal uses the blog's URL as a fallback when there's no name. https://github.com/cuny-academic-commons/cac-onboarding/commit/e9dd8cf86ae216ee83b97484c1b7b39bf7e24914 This will go into the next release.

Actions #11

Updated by Marilyn Weber over 4 years ago

Thanks!

Actions #12

Updated by Matt Gold over 4 years ago

great, smart solution. thanks!

Actions #13

Updated by Boone Gorges over 4 years ago

  • Status changed from Staged for Production Release to Resolved
Actions

Also available in: Atom PDF